-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gulpfile tasks in release zip, but limit packaged scripts #10311
Conversation
Thanks for the pull request @ggetz!
Reviewers, don't forget to make sure that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a minor comment! I agree with the scripts we left for the release zip and I tested all of them just to be safe.
Thanks @ebogo1! Updated. |
Hm, this is a pretty niche use case but I noticed that if we run I think it's minor enough to not do anything about it in this PR but thought I'd mention it. |
Good point. Maybe we should omit the |
Should the |
Yeah, I think that follows. I also don't see an equivalent command in packages from comparable projects. |
Updated once again. |
Cool, thanks @ggetz! |
Fixes #3911
We removed the
gulpfile
in #10281, but after seeing #6025, I think that was the wrong move.The reason we removed it was that it was no longer possible to run any gulp tasks from within the release zip. However, this was due to #8659 is fixed here by including
.gulp.json
.Additionally, it's only possible and helpful a subset of scripts in the release zip. So this PR limits those to the following list:
start
start-public
clean
cloc
coverage
eslint
build-specs
test-*
prettier-check
This list is arrived at by omitting build and watch tasks, as well as the
deploy-*
tasks. IncludinggenerateDocumentation
andbuild-ts
is arguable since they can be run to verify the validity of the docs. But we already included the generated output, and the size of the documentation build tools are not as negligable as eslint or prettier.In order to run those, we include include
.eslintrc.json
,.eslintignore
, related eslint config files in the release zip (~7KB uncompressed);.prettierignore
(<1KB uncompressed); andSpecs/**
which was previously, but I believe erroneously, excluded in #10281.Finally, after #10293 adds back the browser spec runner and associated files, we can re-add the link to the spec runner removed from
index.release.html
in #10184.