-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes Specs, gulpfile.cjs and web.config file from makeZipFile #10281
Conversation
Thanks for the pull request @sanjeetsuhag!
Reviewers, don't forget to make sure that:
|
|
As I understand, the users are not meant to run Cesium dev tasks or build the source code from within the release zip. However, they technically could before this PR. Without |
OK, so if it's not changing the behavior, my second comment shouldn't matter. |
@ggetz I've restored the |
Nope, thanks @sanjeetsuhag! |
Fixes #10270
main
remove-specs-from-zip
I noticed that we don't really do much with the
gulpfile.cjs
and theweb.config
files, so this PR removes them too. Not sure if that's the right thing to do, but none of the commands through gulp from inside the zip file anyway.