Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gulpfile tasks in release zip, but limit packaged scripts #10311

Merged
merged 6 commits into from
Apr 21, 2022
Merged

Fix gulpfile tasks in release zip, but limit packaged scripts #10311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fd7cdd2
Add support files to release zip
ggetz Apr 19, 2022
f309ed4
remove scripts in makeZipFile
ggetz Apr 20, 2022
ea081e6
Merge branch 'main' into packaged-scripts
ggetz Apr 21, 2022
78f65b3
Remove un-needed ignore
ggetz Apr 21, 2022
c249f32
remove duplicate line
ggetz Apr 21, 2022
7b2782e
Remove clean and cloc task from release zip
ggetz Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ ThirdParty/**
Tools/**
Apps/Sandcastle/jsHintOptions.js
Apps/Sandcastle/gallery/gallery-index.js
index.html
index.release.html
34 changes: 34 additions & 0 deletions gulpfile.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,30 @@ gulp.task(

// Remove prepare step from package.json to avoid running "prepare" an extra time.
delete packageJson.scripts.prepare;

// Remove build and transform tasks since they do not function as intended from within the release zip
delete packageJson.scripts.convertToModules;
delete packageJson.scripts.build;
delete packageJson.scripts["build-watch"];
delete packageJson.scripts["build-ts"];
delete packageJson.scripts.buildApps;
delete packageJson.scripts.clean;
delete packageJson.scripts.cloc;
delete packageJson.scripts.combine;
delete packageJson.scripts.combineRelease;
delete packageJson.scripts.generateDocumentation;
delete packageJson.scripts["generateDocumentation-watch"];
delete packageJson.scripts.makeZipFile;
delete packageJson.scripts.minify;
delete packageJson.scripts.minifyRelease;
delete packageJson.scripts.release;
delete packageJson.scripts.prettier;

// Remove deploy tasks
delete packageJson.scripts["deploy-s3"];
delete packageJson.scripts["deploy-status"];
delete packageJson.scripts["deploy-set-version"];

fs.writeFileSync(
"./Build/package.noprepare.json",
JSON.stringify(packageJson, null, 2)
Expand All @@ -475,10 +499,20 @@ gulp.task(
const staticSrc = gulp.src(
[
"Apps/**",
"Apps/**/.eslintrc.json",
"!Apps/Sandcastle/gallery/development/**",
"Source/**",
"Source/**/.eslintrc.json",
"Specs/**",
"Specs/**/.eslintrc.json",
"ThirdParty/**",
"Tools/eslint-config-cesium/**",
"favicon.ico",
".eslintignore",
".eslintrc.json",
".gulp.json",
".prettierignore",
"gulpfile.cjs",
"server.cjs",
"index.cjs",
"LICENSE.md",
Expand Down
4 changes: 4 additions & 0 deletions index.release.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,10 @@ <h2>Local links</h2>
Sandcastle can be saved and downloaded.
</td>
</tr>
<tr>
<td><a href="Specs/SpecRunner.html">Run tests</a></td>
<td>Run Cesium's full suite of unit tests</td>
</tr>
</tbody>
</table>
</div>
Expand Down