Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable OIT by default for iOS and iPad #10337

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Apr 29, 2022

Due to increased reports of #9827, this disables orderIndependentTranslucency by default on iOS and iPad as a temporary workaround.

@ggetz ggetz requested a review from ebogo1 April 29, 2022 15:59
@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

Copy link
Contributor

@ebogo1 ebogo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I assume navigator.platform works as expected but I don't have any iOS devices to test on. Have we checked that this branch fixes issues on the newer devices?

@ggetz
Copy link
Contributor Author

ggetz commented Apr 29, 2022

Thanks @ebogo1.

Have we checked that this branch fixes issues on the newer devices?

Do you mean other than the issues which were brought up in #9827?

@ebogo1
Copy link
Contributor

ebogo1 commented Apr 29, 2022

I meant more to check that navigator.platform was identifying iOS devices as the iPad iPhone iPod strings. I couldn't find an official list of its possible values. Happy to merge if we're confident that those are correct, I just wanted to double check.

@ggetz
Copy link
Contributor Author

ggetz commented Apr 29, 2022

I was able to verify this is working on my iPhone, logging the value of Scene.orderIndependentTranslucency:

image

I tried my iPad, which is a iPad Pro. Unfortunately I believe this type of iPad always presents the desktop version of a website, so the value of navigator.platform is MacIntel, same as my desktop. However, I believe it should work for smaller and older models of iPad.

@ebogo1
Copy link
Contributor

ebogo1 commented Apr 29, 2022

Cool, thanks @ggetz!

@ebogo1 ebogo1 merged commit 669fef6 into main Apr 29, 2022
@ebogo1 ebogo1 deleted the ios-oit-workaround branch April 29, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants