Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the extension check required for OIT #10417

Merged
merged 5 commits into from
Jun 1, 2022
Merged

Fixes the extension check required for OIT #10417

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6dec139
Adds check for GL_EXT_float_blend when enabling OIT
sanjeetsuhag Jun 1, 2022
bc9c1d5
Removes OIT restriction on iOS devices
sanjeetsuhag Jun 1, 2022
44abd5b
Add to CHANGES.md
sanjeetsuhag Jun 1, 2022
353d449
Adds breaking change to CHANGES.md
sanjeetsuhag Jun 1, 2022
431c7d1
eslint fix
sanjeetsuhag Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

##### Fixes :wrench:

- Fixed the rendering issues related to order-independent translucency on iOS devices. [#10417](https://github.com/CesiumGS/cesium/pull/10417)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is how we should phrase it or if it needs to go into breaking changes (since the workaround initially went in breaking changes)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would definitely add a bullet mentioning that the workaround has been removed. That new bullet probably belongs in breaking changes.

- Fixed the inaccurate computation of bounding spheres for models not centered at (0,0,0) in their local space. [#10395](https://github.com/CesiumGS/cesium/pull/10395)
- Fixed the inaccurate computation of bounding spheres for `ModelExperimental`. [#10339](https://github.com/CesiumGS/cesium/pull/10339/)
- Fixed error when destroying a 3D tileset before it has finished loading. [#10363](Fixes https://github.com/CesiumGS/cesium/issues/10363)
Expand Down
3 changes: 2 additions & 1 deletion Source/Scene/OIT.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ function OIT(context) {
this._translucentMultipassSupport = false;
this._translucentMRTSupport = false;

const extensionsSupported = context.colorBufferFloat && context.depthTexture;
const extensionsSupported =
context.colorBufferFloat && context.depthTexture && context.floatBlend;
this._translucentMRTSupport = context.drawBuffers && extensionsSupported;
this._translucentMultipassSupport =
!this._translucentMRTSupport && extensionsSupported;
Expand Down
4 changes: 1 addition & 3 deletions Source/Scene/Scene.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,9 +226,7 @@ function Scene(options) {
this._computeCommandList = [];
this._overlayCommandList = [];

// OIT is temporally disabled by default on iPad and iOS mobile due to https://github.com/CesiumGS/cesium/issues/9827
const defaultOIT = !FeatureDetection.isIPadOrIOS();
this._useOIT = defaultValue(options.orderIndependentTranslucency, defaultOIT);
this._useOIT = defaultValue(options.orderIndependentTranslucency, true);
this._executeOITFunction = undefined;

this._depthPlane = new DepthPlane(options.depthPlaneEllipsoidOffset);
Expand Down