Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip build/rebuild when serving in release zip #10904

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Nov 15, 2022

(Most of the changes here are whitespace changes. You can ignore with the PR code display settings.)

@ggetz ggetz requested a review from sanjeetsuhag November 15, 2022 17:12
@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

Copy link
Contributor

@sanjeetsuhag sanjeetsuhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks @ggetz!

@sanjeetsuhag sanjeetsuhag merged commit 43c875a into main Nov 16, 2022
@sanjeetsuhag sanjeetsuhag deleted the start-static branch November 16, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static npm start inside release ZIP file
3 participants