North-up viewing of high-orbit objects #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose this also fixes #824? |
|
Yes it does fix #824, I forgot to mention. The "pop" is where the Molniya becomes slow as measured in Fixed frame, as they are designed to do at the top half of their orbit, and we incorrectly switch to East-North-Up. With this pull, they stay on the new North-Up view for their entire orbit. |
| Cartesian3.normalize(cartesian, zBasis); | ||
| Cartesian3.normalize(deltaCartesian, deltaCartesian); | ||
|
|
||
| Matrix3.multiplyByVector(toInertial, zBasis, zBasis); |
There was a problem hiding this comment.
You can just normalize inertialCartesian and inertialDeltaCartesian and remove these matrix multiplies.
There was a problem hiding this comment.
Talked in person. Update soon.
|
I think all comments so far have been addressed. |
bagnell
added a commit
that referenced
this pull request
Jun 4, 2014
North-up viewing of high-orbit objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DynamicObjectView.jsalready knows how to auto-select East-North-Up or VVLH for different objects based on their fixed-frame velocity. This pull adds some logic to introduce a "North-Up" view for high objects like GEO and Molniya spacecraft, and passing asteroids. The new view shows the Earth "rightside-up" (with the North Pole oriented towards the top of the screen) behind the tracked object. This new view is automatically selected in a manner partially inspired by camera mechanics in the game Kerbal Space Program.