-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KHR_common_materials compatibility (merge to gltf-materials) #3410
Merged
pjcozzi
merged 19 commits into
CesiumGS:gltf-materials
from
mlimper:KHR_common_materials-compatibility
Jan 12, 2016
Merged
KHR_common_materials compatibility (merge to gltf-materials) #3410
pjcozzi
merged 19 commits into
CesiumGS:gltf-materials
from
mlimper:KHR_common_materials-compatibility
Jan 12, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be done on writer side)
…om/mlimper/cesium into KHR_common_materials-compatibility
mlimper
changed the title
Khr common materials compatibility
KHR_common_materials compatibility (merge to gltf-materials)
Jan 12, 2016
Thanks again @mlimper! From here, I will open a PR for master with a tasklist for us to update our sample models. I'll CC you on the new PR in case you want to stay in the loop. |
pjcozzi
added a commit
that referenced
this pull request
Jan 12, 2016
KHR_common_materials compatibility (merge to gltf-materials)
Thanks, that would be nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #3294, now targeting the gltf-materials branch