glTF material improvements #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be done on writer side)
…om/mlimper/cesium into KHR_common_materials-compatibility
KHR_common_materials compatibility (merge to gltf-materials)
|
Should be doable from my end. |
|
@tfili any update here? |
|
@pjcozzi Just have to update the models. |
# Conflicts: # CHANGES.md # Source/Scene/Model.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3410 by @mlimper, now targeted for master. I also added tweaks e0c2716 and f539f48.
@tfili can you finish this for the 1.18 release?
"binary_glTF"bufferScene/Model loads a glTF with KHR_materials_common using an ambient lighttest. @mlimper did you run the tests?@lilleyse do you need to update OBJ2GLTF for the fix to KHR_materials_common?