Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gltf 2.0 #5641

Merged
merged 140 commits into from
Aug 1, 2017
Merged

Gltf 2.0 #5641

merged 140 commits into from
Aug 1, 2017

Conversation

moneimne
Copy link
Contributor

@moneimne moneimne commented Jul 18, 2017

Continuation of #4808.

To do:

  • Upgrade all test models in specs/data
  • Write tests for morph targets
  • Remove gltf-sample-models from this branch, use simpler test models instead
  • Investigate hemispheric lighting some more
  • support for sparse accessors
  • include some glTF 1.0 models in the Apps/SampleData folder for easy visual testing in Sandcastle
  • Update CHANGES.md
  • Update LICENSE.md

pjcozzi and others added 30 commits August 30, 2016 10:32
glTF 1.0.1 Adds support for normalized vertex arrays and a test
…cissor-test

glTF 1.0.1 remove scissor test
…extensions-1.0.1

Test glTF for required extensions.
@lilleyse lilleyse force-pushed the gltf-2.0 branch 2 times, most recently from 487fafd to f5843f0 Compare July 31, 2017 02:47
@lilleyse
Copy link
Contributor

Added some fixes for broken tilesets. Will investigate the new "destroy" related test failures next, as well as the Classification Demo.

@lilleyse
Copy link
Contributor

A snapshot of the performance of going around the BIM tileset. The results seem pretty reasonable, about as much time in upgrading gltf 1.0 to 2.0 as initializing the b3dm.
perf

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 31, 2017

Profile is probably fine, but it would be better to run without the readPixels bottleneck.

@lilleyse
Copy link
Contributor

Performance numbers without readPixels. Looks fine.

perf2

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 31, 2017

Thanks, I agree, looks OK. Later we could make the 1.0 -> 2.0 path a bit faster if we need, but would rather focus on 2.0.

LICENSE.md Outdated
@@ -754,7 +779,7 @@ http://svs.gsfc.nasa.gov/vis/a000000/a003500/a003572/

Terms of use: http://www.nasa.gov/audience/formedia/features/MP_Photo_Guidelines.html

### Some vector icons from (or inspired by) Raphaël JS
### Some vector icons from (or inspired by) Rapha?l JS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some kind of Unicode fail happening in this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this in my branch, PR: moneimne#3

@lilleyse
Copy link
Contributor

lilleyse commented Aug 1, 2017

I think we are all set now! All the 1.0 and 2.0 sample models have been thoroughly tested, as well as a variety of 3D Tiles tilesets. It's hard to catch everything, so definitely let us know if you have issues loading models or tilesets. Also for 2.0 models check out the glTF-validator to aid with testing.

There are some known issues here:

Thanks to everyone who worked on this: @lasalvavida for laying the foundation and keeping up with the 1.0-2.0 changes from the start, @emackey for the procedural PBR reflection and merge assistance, @moneimne for writing the PBR shaders and bringing everything to production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants