Fix geometry offset attribute for 2D and CV #6753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hpinkos, thanks for the pull request! Maintainers, we have a signed CLA from @hpinkos, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
4 tasks
|
Fixed the eslint error |
bagnell
reviewed
Jun 28, 2018
Source/Scene/Primitive.js
Outdated
| var offsetScratchCartesian = new Cartesian3(); | ||
| function updateBatchTableOffsets(primitive, frameState) { | ||
| var hasOffset = defined(primitive._batchTableAttributeIndices.offset); | ||
| if (!hasOffset|| primitive._batchTableOffsetsUpdated || frameState.scene3DOnly) { |
Source/Scene/Primitive.js
Outdated
| } | ||
|
|
||
| var center = boundingSphere.center; | ||
| center = ellipsoid.scaleToGeodeticSurface(center, center); |
There was a problem hiding this comment.
You don't want to modify the bounding sphere right? Should this use a scratch variable?
|
Thanks @bagnell ! Updated |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offset vector needs to be projected for 2D and columbus view
Also fixed the doc for
OffsetGeometryInstanceAttributeAlso, partial fix for #6365. I wrapped the distance display condition 2D bounding sphere calculations in
if (!frameState.scene3DOnly)so the example to longer crashes whenscene3DOnly: true.