Height Reference for Corridor, Ellipse, Polygon and Rectangle #6717

hpinkos · 2018-06-21T22:00:14Z

Finishes up #6434

Adds GeometryHeightProperty for specifying a HeightReference for CorridorGraphics, EllipseGraphics, PolygonGraphics, and RectangleGraphics. This can be used for polygons with a height and/or extruded
height to specify HeightReference.RELATIVE_TO_GROUND or HeightReference.CLAMP_TO_GROUND. Note that using this property does not make the geometry conform to terrain. But it can be used to make the flat polygon be at a certain height above the terrain that is loaded.

The general idea is that we create the geometry, then when terrain LOD changes we move the positions in the shader so the height remains relative to terrain. When height is RELATIVE_TO_TERRAIN and extrudedHeight is CLAMP_TO_TERRAIN, we use ApproximateTerrainHeights.json to set the bottom height and only the positions of the top points change when terrain changes. In the Entity API, the end users can simply use the GeometryHeightProperty to specify the height reference and the rest happens behind the scenes.

Here are two use cases:

viewer.entities.add({
    name: 'Extruded polygon on terrain with a height of 10 m',
    polygon : {
        hierarchy : positions,
        material : Cesium.Color.fromRandom({alpha: 1}),
        height : new Cesium.GeometryHeightProperty(10.0, Cesium.HeightReference.RELATIVE_TO_GROUND),
        extrudedHeight : new Cesium.GeometryHeightProperty(0.0, Cesium.HeightReference.CLAMP_TO_GROUND)
    }
});

viewer.entities.add({
    name : 'Corridor at 30m above terrain',
    corridor : {
        positions : positions,
        width : 10.0,
        material : Cesium.Color.RED.withAlpha(0.5),
        height : new Cesium.GeometryHeightProperty(30.0, Cesium.HeightReference.RELATIVE_TO_GROUND),
    }
});

Details:

Added GeometryHeightProperty, which has a height number value and a heightReference property. heightReference defaults to NONE.
If CLAMP_TO_GROUND is used for the extrudedHeight we find the value using ApproximateTerrainHeights
Because all geometry in a batch have to have the same attributes, I created new batches in GeometryVisualizer for geometries that have the offset attribute
Added GroundGeometryUpdater abstract class used by CorridorGeometryUpdater, EllipseGeometryUpdater, PolygonGeometryUpdater and RectangleGeometryUpdater (I made the same change in, it just happens that the same geometry types that can be z-ordered are the ones with the height/extrudedHeight properties Z-ordering for ground geometry entities #6362)
The GroundGeometryUpdater child classes have a _computeCenter function to return the position on terrain the height is relative to (polygon, ellipse and rectangle height is relative to the position in the center of the geometry, and I arbitrarily decided corridor height is relative to the middle position in the list of positions)
Added TerrainOffsetProperty, which is a private class. This is a dynamic property that is used to update the value of the offset geometry instance attribute when terrain LOD changes. When height reference is RELATIVE_TO_GROUND, GroundGeometryUpdater creates a this.terrainOffsetProperty = new TerrainOffsetProperty(...). Otherwise this.terrainOffsetProperty is a ConstantProperty with a value of Cartesian3.ZERO

TODO

cesium-concierge · 2018-06-21T22:00:16Z

@hpinkos, thanks for the pull request! Maintainers, we have a signed CLA from @hpinkos, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

pjcozzi · 2018-06-25T14:39:05Z

@hpinkos who is the right person - or people? - to review this? Would like to get this merged soon for the next release and to finish this project up.

mramato · 2018-06-25T14:49:05Z

@pjcozzi I'm already on the hook for reviewing this today. This is the second part of a partially reviewed PR (#6434) that was split into 2 (one for primitive changes one for Entity changes), so I'm not expecting any major surprises. This one is entity API one, the primitive one has already been merged.

Of course if anyone else wants to take a crack at it, I'm more than happy to have the help.

mramato · 2018-06-25T20:28:42Z

Apps/Sandcastle/gallery/Geometry Height Reference.html

@@ -0,0 +1,86 @@
+<!DOCTYPE html>


My comments in #6434 (comment) still apply here. I would also like to see some inline comments to explain the feature. If I'm just trying to learn Cesium's capabilities from Sandcastle examples, there's very little context here.

mramato · 2018-06-25T20:33:01Z

Source/DataSources/RectangleGeometryUpdater.js

        GeometryUpdater,
        GroundGeometryUpdater,
        Property) {
    'use strict';

    var scratchColor = new Color();
+    var defaultOffset = Cartesian3.ZERO;
+    var offsetScratch = new Cartesian3();
+    var scratchRectangleGeometry = new RectangleGeometry({rectangle: new Rectangle()});


Is this whole setOptions approach because we are concerned about performance? Did we measure to see if it actually had any affect? Seems like a lot of changes for possibly no change in performance.

I didn't test performance. It just seemed like a good idea to be able to use a scratch variable. But I think I'm going to revert it.

I guess I'll wait to do this until you reply to my question on your other comment

Addressed in #6733

mramato · 2018-06-25T20:33:36Z

Source/DataSources/RectangleGeometryUpdater.js

+
+        if (extrudedHeight instanceof GeometryHeightProperty && Property.getValueOrDefault(extrudedHeight.height, Iso8601.MINIMUM_VALUE, HeightReference.NONE) === HeightReference.CLAMP_TO_GROUND) {
+            scratchRectangleGeometry.setOptions(options);
+            options.extrudedHeight = GeometryHeightProperty.getMinimumTerrainValue(scratchRectangleGeometry.rectangle);


This is confusing, why are we setting extrudedHeight after we pass it to setOptions? Does order matter here because it looks like a bug if not and is confusing if so.

Obviously this and other comments apply to the other geometries as well, but I won't comment anywhere except RectangleGeoemtryUpdater to avoid noise.

OK, I see what's going on here, but this seems like a really backwards way to do this. We are using a scratch geometry instance simply so we can call .rectangle on it to pass to GeometryHeightProperty.getMinimumTerrainValue? This makes me think that something is being done at the wrong level of abstraction. Why can't we add an option to the geometries so that we don't have to create a scratch one just for this use case?

Why can't we add an option to the geometries so that we don't have to create a scratch one just for this use case

What do you mean by this? I don't get it.

If I'm reading the code correctly, we are using a scratchRectangleGeometry to compute the rectangle property which we then use to compute another value and set it back onto options of a different RectangleGeometry that gets created later. That seems a little behind your back to get to your elbow to me.

It also means that rectangle gets computed up front for the geometry on the main thread (and I assume computed again later during tessellation?) Why doesn't the geometry just take the options needed to do the extrudedHeight computation itself during tessellation?

There could be a good reason we're doing it this way, but from the outside looking in it seems like there needs to be a cleaner way.

Addressed in #6733

mramato · 2018-06-25T20:39:45Z

Source/DataSources/RectangleGeometryUpdater.js

-            };
+            attributes.color = ColorGeometryInstanceAttribute.fromColor(currentColor);
+        }
+        if (defined(this._options.offsetAttribute)) {


Why not move this into the attributes initialization? Would keep the shape of the object the shame, also initialize color to undefined as well (for the same reason), This way attributes always has the same properties.

Why does this matter? I'm pretty sure the result would be the same regardless.

It's so browsers can better optimize the code. If attributes always has the same set of properties (even if some are undefined) the browser can do a better job of optimizing compared to attributes sometimes having an offset property and sometimes not.

mramato · 2018-06-25T20:44:12Z

Source/DataSources/GroundGeometryUpdater.js

        }
    });

+    /**
+     * @param {Entity} entity


Since none of the other private functions in this file have doc, I would just remove it for now for consistency. (if you really want to keep it, we should flesh it out).

Looks like the doc that's here is wrong anyway.

mramato · 2018-06-25T20:55:13Z

Source/DataSources/GeometryHeightProperty.js

+    'use strict';
+
+    /**
+     * A {@link Property} which computes height or extrudedHeight for a {@link CorridorGraphics}, {@link EllipseGraphics}, {@link PolygonGraphics} or {@link RectangleGraphics}.


Perhaps better explain flesh this out to mention that the computed height is in relation to the current terrain visualization and/or specified height reference. computes height doesn't really explain anything without context.

mramato · 2018-06-25T21:09:15Z

Source/DataSources/GeometryVisualizer.js

-        this._closedMaterialBatches = new Array(numberOfShadowModes);
-        this._openColorBatches = new Array(numberOfShadowModes);
-        this._openMaterialBatches = new Array(numberOfShadowModes);
+        this._outlineBatches = new Array(numberOfShadowModes*2);


Ugh, are we doubling the number of all batches here?

Yes, because not all geometry types have support for the applyOffset vertex attribute required for the GeometryOffsetInstanceAttribute. If we didn't want to double the size of the batches I suppose I could add an applyOffset option to BoxGeometry, CylinderGeometry and all the others. This seemed like a better solution to me.

There's only one GeometryVisualizer per-datasource these days, right? If so then I suppose this is OK for now.

Although, ultimately wouldn't it make sense to have the offset and clamping capabilities to these other geometries as well?

Yes, only one GeometryVisualizer per datasource.
And yes, this should let us do clamping with the other geometry types but the solution would be a bit difference since this relies on setting height and/or extrudedHeight

mramato · 2018-06-25T21:10:52Z

Source/DataSources/GeometryVisualizer.js

                } else {
-                    this._closedMaterialBatches[shadows].add(time, updater);
+                    // eslint-disable-next-line no-lonely-if


Why are we disabling the rule here instead of following it? (same comment throughout)

I think I was afraid of messing up the if logic here

That's what unit tests are for. You just need to move the if/else up one, please remove these disables.

mramato · 2018-06-25T21:12:56Z

I'm still going through this, will have more comments either later tonight or tomorrow morning.

mramato · 2018-06-26T13:19:54Z

Source/DataSources/GroundGeometryUpdater.js

+        var heightProperty = geometry.height;
+        var extrudedHeightProperty = geometry.extrudedHeight;
+
+        if (this._terrainOffsetProperty instanceof TerrainOffsetProperty) {


Shouldn't this just be a defined check? When wouldn't _terrainOffsetProperty be anything other than an instance of TerrainOffsetProperty?

mramato · 2018-06-26T13:23:58Z

Source/DataSources/RectangleGeometryUpdater.js

@@ -203,6 +232,12 @@ define([
        options.granularity = defined(granularity) ? granularity.getValue(Iso8601.MINIMUM_VALUE) : undefined;
        options.stRotation = defined(stRotation) ? stRotation.getValue(Iso8601.MINIMUM_VALUE) : undefined;
        options.rotation = defined(rotation) ? rotation.getValue(Iso8601.MINIMUM_VALUE) : undefined;
+        options.offsetAttribute = GeometryHeightProperty.computeGeometryOffsetAttribute(height, extrudedHeight, Iso8601.MINIMUM_VALUE);
+
+        if (extrudedHeight instanceof GeometryHeightProperty && Property.getValueOrDefault(extrudedHeight.height, Iso8601.MINIMUM_VALUE, HeightReference.NONE) === HeightReference.CLAMP_TO_GROUND) {


We need to avoid checks like this in the Entity API because it means that the properties are no longer composable or referenceable (i.e. what if I use a CompositeProperty so that sometimes the inner property is using GeometryHeightProperty and sometimes it isn't?). This also means that things like ReferenceProperty won't work.

…-reference

hpinkos · 2018-06-26T21:39:48Z

@mramato ready for another look

mramato · 2018-06-27T13:40:52Z

Please merge in master, also looks like you have some eslint issues.

mramato · 2018-06-27T13:46:32Z

Apps/Sandcastle/gallery/Geometry Height Reference.html

+    }
+}
+
+viewer.scene.camera.flyTo({


We shouldn't hard code camera numbers because the result is not the same for all screen sizes/aspect ratios and it also makes Cesium look hard to use. Use the viewer zoom functions instead, if you can't do this view with those, right up an issue.

Yeah, I just did this because I was trying to find a spot that you could see the polygons both with and without terrain

Well actually, this doesn't work for the same reason viewer.flyTo doesn't really work for billboards on terrain. The position changes as the terrain loads in.

mramato · 2018-06-27T13:47:24Z

Apps/Sandcastle/gallery/Geometry Height Reference.html

+});
+viewer.scene.globe.depthTestAgainstTerrain = true;
+
+Sandcastle.addToolbarButton('Enable Terrain', function() {


I would make this a checkbox instead of a button and perhaps fly the camera to the location when it changes (because the shapes went mostly out of view when I toggled it because they dropped so far).

mramato · 2018-06-27T13:51:45Z

Apps/Sandcastle/gallery/Geometry Height Reference.html

+    'use strict';
+//Sandcastle_Begin
+var cesiumTerrainProvider = Cesium.createWorldTerrain();
+var ellipsoidTerrainProvider = new Cesium.EllipsoidTerrainProvider();


A line break could probably help here.

mramato · 2018-06-27T13:52:11Z

Apps/Sandcastle/gallery/Geometry Height Reference.html

+    baseLayerPicker: false,
+    terrainProvider: cesiumTerrainProvider
+});
+viewer.scene.globe.depthTestAgainstTerrain = true;


Maybe a comment stating why we need to enable depthTestAgainstTerrain for this demo.

mramato · 2018-06-27T13:52:25Z

Apps/Sandcastle/gallery/Geometry Height Reference.html

+    viewer.scene.terrainProvider = ellipsoidTerrainProvider;
+});
+
+


Extra whitespace

mramato · 2018-06-27T13:52:48Z

Apps/Sandcastle/gallery/Geometry Height Reference.html

+var baseLat = 45.89546589994886;
+var delta = 0.001;
+function addEntity(i, j) {
+    var lon1 = baseLon + delta*i;


Run the formatter on this example

mramato · 2018-06-27T13:53:55Z

Apps/Sandcastle/gallery/Geometry Height Reference.html

+
+    var lat1 = baseLat + delta*j;
+    var lat2 = baseLat + delta*j + delta;
+    var a = Cesium.Cartesian3.fromDegrees(lon1, lat1);


Try looking at this with beginners eyes. Can be do better with variable names here? Is this north/source/east/west? Why are these polygons instead of rectangles?

hpinkos · 2018-06-27T16:44:51Z

@mramato ready for another look

hpinkos · 2018-06-27T18:16:47Z

Source/Scene/Primitive.js

@@ -1341,6 +1341,7 @@ define([

        for (i = 0; i < result.length; i++) {
            var boundingSphere = result[i].clone(primitive._boundingSpheres[i]);
+            console.log(boundingSphere.radius);


mramato · 2018-06-27T18:17:18Z

Source/DataSources/GeometryHeightProperty.js

+            height = 0;
+        }
+
+        var result = this._resultObject;


As discussed offline, to not break the interface we can do height = new Number(height) here and glob heightReference onto that. I'm not crazy about it, but it will still be cleaner than what we're doing now.

mramato · 2018-06-27T18:37:40Z

Looks like the example doesn't work in IE11.

mramato · 2018-06-27T18:46:51Z

I discussed some concerns with @hpinkos offline so she's going to split out the new properties into separate heightReference and extrudedHeightReference properties instead of trying to combine it into one numeric property. This should better match the rest of the entity API and not hack around the fact that height should always be a Number and not an object.

…erence

mramato · 2018-06-27T21:03:19Z

@hpinkos I think we're in the home stretch here.

One performance oriented issue I noticed is that TerrainOffsetProperty.prototype.getValue gets called every frame, even for a static view with all terrain loaded. I assume this is because of the hardcoded false for isConstant and some architecture issues with the Entity API. If there's an easy way for TerrainOffsetProperty to know it has the same value as last time, perhaps it could cache it and do no work at all? The function would still get called but it would basically be a get method. If this isn't an easy change to make, please just write up a new issue with some details so we can address it in the future. Thoughts?

…erence

hpinkos · 2018-06-27T22:24:55Z

One performance oriented issue I noticed is that TerrainOffsetProperty.prototype.getValue gets called every frame

This is going to happen regardless because TerrainOffsetProperty will never be constant because the height of the terrain isn't constant. So StaticGeometryColorBatch is going to keep calling getValue every frame.

However, I did change it so it doesn't recompute everything every frame for static geometry. Instead, it will compute the position and normal up front, then only do the 'multiply by terrain height' calculation every frame.

…ght-reference

mramato · 2018-06-27T23:48:46Z

@hpinkos I merged in master.

Have you tested this at all in 2D/CV? I think it's broken:

hpinkos · 2018-06-28T15:06:33Z

@mramato I'm going to open a separate PR for that because it's a primitive level bug that's already in master.

Anything else for this PR?

mramato · 2018-06-29T00:29:54Z

@hpinkos this still doesn't work in 2D or CV for me. Here's the Sandcastle I used http://localhost:8080/Apps/Sandcastle/index.html#c=zVZbc+I2FP4rGl4wjWNgCwxsSKZpQpvMJAvDsum0y05G2AcsIktUksnSDP+9R76AubV56EOdBxPp+875dG7ykirig2ZxNAKlKBMDJZcsAEUuyU2y7vkKqIHfpOJBhnEqF2OxRCZwzhZasuCQLOA1N9A7gUrMpIaWDF73aU/JmlNO5d1IYZALquySt7Eg+Eyohge6AjVg/guyP5Ip5RrcdNfsSfp4/JxjsU5lVKskgIUJkagNoTPE4DuzQpgmCv6MmYKAGEki+gLEhEAWkq9mUmjicxot7FbGSAxaE0ADIqdEh/KViRmSlIxnIWGGTJWMSCxQxAzXRIChSI7saR8EeDMuJ+AlmkYo6TpVlMnHUBkVQ6L8MxWBT7Xh4NEgGEnJJ1Q9goidr295LL4bDEA5J/cEnXAIylmoUD9w8C1kGgvfMIkpzqNsnx1d5iDXRwN7kdLXGOBNxvZ13DL9nwo5VY8FLd+2RcelmDETB4DMltdu1lr1ZqeNf7Xmh3pW4ZyaHNJoeu1Os9FqtjudTqPdbmWQALihuF/zarV6YjzXTjAdPYEGVg5zyXxzEst6tVV2WdBwlhn6gbCLLQzoaVj+O/GZE7SMsYYvt8K3hHnBrpDqJKxgN4fT7Ti4oQo7hFHxo2cL+BZmCkA79jxu6r1SIE7eSUz0FIn+vxJtaI4Qg3cSN1K31IXUzOZNo4mv1CUTl/guCb7l1tPiA5tRBto2m1OozWwUYO0WFu0TMlBU+eEKtzYu3F1MhCNWMcoRkouXXKpE9xD7W0bOG+WLkCKgvq7ssUNgs9B2TQOL8OjeEKagQPiwdXC3u+ENew/Xo/un3vOo//zrsP/l0+2eJWxehaUS3OXeDp3tQt7h9Obh+nGw9bi1ts5a1mZonc3n9CYi9dZ27JqQ4rBWQDT2+flkdW7f2IFSEcemlNnGvMBXlzTwdXa2acINZJ5C5ilkXoDYZ6+FC5MkGSNpSfg0whR7XMqXa+P8c/VtWtndNJ9LmrVaxS1efnd4beB1MWDGDzH/M8itPlITeoN7l5zvLjz3n3rD51/6X4Yu+VBDc8kdfUTeSFGh8fBRwaJi3xve/W3v0+h+9Hvl9KXyc2wMjuTyH1JGeA8fzuj/eTxOSXxHTCw1+VYouaWuNisOV6m9n1i0wBlEYsUdz6saiBZ4DtDVSYxfJcbztbauu9Wc1A3YkrDgclza+7IZl+xXhNa4M405/8z+gnHpqltF/A6NyyQW/SUoTlcWEtavHtJFz/O6Vfz3kGXSFBYs/g0

hpinkos · 2018-06-29T02:28:04Z

@mramato ready. Apparently the position sent to the ground clamping callback is already projected to so I had to account for that

hpinkos · 2018-06-29T13:38:15Z

Can someone please confirm that 2D and CV work and merge this ASAP? @mramato @ggetz @lilleyse @likangning93

ggetz · 2018-06-29T13:46:19Z

Haven't looked at the rest of this, but the Sandcastle @mramato provided looks good in 2D and CV now.

likangning93 · 2018-06-29T13:47:27Z

Can confirm that Sandcastle in the deployment works too.

mramato · 2018-06-29T14:32:14Z

Sorry to worry you @hpinkos started to look at this an hour ago and got pulled away. Finishing up now.

mramato · 2018-06-29T14:38:06Z

3D/2D/CV all work. Tests are passing and I've looked at the code too many times to have any more useful comments. 😄

Thanks @hpinkos this turned out to be a really cool feature.

hpinkos requested a review from mramato June 21, 2018 22:02

mramato reviewed Jun 25, 2018

View reviewed changes

mramato reviewed Jun 26, 2018

View reviewed changes

hpinkos mentioned this pull request Jun 26, 2018

Add static computeRectangle function to CorridorGeometry, EllipseGeometry, PolygonGeometry and RectangleGeometry #6733

Merged

geometry height reference property

31448d7

hpinkos force-pushed the entity-geometry-height-reference branch from 06f31f1 to 31448d7 Compare June 26, 2018 19:32

hpinkos added 3 commits June 26, 2018 15:32

Merge branch 'geometry-compute-rectangle' into entity-geometry-height…

3dd3914

…-reference

cleanup

6522aa5

fix instanceof and sandcastle example

cae76e9

mramato reviewed Jun 27, 2018

View reviewed changes

eslint

4c6a6b2

hpinkos commented Jun 27, 2018

View reviewed changes

mramato reviewed Jun 27, 2018

View reviewed changes

hpinkos added 3 commits June 27, 2018 14:47

cleanup

a6a4d1f

okay, I guess that wasn't so bad

fb85bdd

Merge branch 'fix-ie-offset-geometry' into entity-geometry-height-ref…

1ef29b5

…erence

hpinkos added 2 commits June 27, 2018 17:33

Merge branch 'fix-ie-offset-geometry' into entity-geometry-height-ref…

e9d6eb8

…erence

terrain offset performance

787a99a

Merge remote-tracking branch 'origin/master' into entity-geometry-hei…

4f7b6c4

…ght-reference

hpinkos added 3 commits June 28, 2018 15:08

CHANGES.md

eb0974f

Merge branch 'offset-2d' into entity-geometry-height-reference

1ee4e6e

Merge branch 'offset-2d' into entity-geometry-height-reference

4c3f1d0

hpinkos added 2 commits June 28, 2018 21:34

Merge branch 'master' into entity-geometry-height-reference

f41cd2d

fix height 2D/CV

04a8259

mramato merged commit 11ea6b0 into master Jun 29, 2018

mramato deleted the entity-geometry-height-reference branch June 29, 2018 14:38

Height Reference for Corridor, Ellipse, Polygon and Rectangle #6717

Height Reference for Corridor, Ellipse, Polygon and Rectangle #6717

Conversation

hpinkos commented Jun 21, 2018 • edited by mramato Loading

cesium-concierge commented Jun 21, 2018

pjcozzi commented Jun 25, 2018

mramato commented Jun 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mramato commented Jun 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hpinkos commented Jun 26, 2018

mramato commented Jun 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hpinkos commented Jun 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mramato commented Jun 27, 2018

mramato commented Jun 27, 2018

mramato commented Jun 27, 2018

hpinkos commented Jun 27, 2018

mramato commented Jun 27, 2018

hpinkos commented Jun 28, 2018

mramato commented Jun 29, 2018

hpinkos commented Jun 29, 2018

hpinkos commented Jun 29, 2018

ggetz commented Jun 29, 2018 • edited Loading

likangning93 commented Jun 29, 2018

mramato commented Jun 29, 2018

mramato commented Jun 29, 2018

hpinkos commented Jun 21, 2018 •

edited by mramato

Loading

ggetz commented Jun 29, 2018 •

edited

Loading