Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3D Tiles credits #7877

Merged
merged 2 commits into from
May 29, 2019
Merged

Fix 3D Tiles credits #7877

merged 2 commits into from
May 29, 2019

Conversation

lilleyse
Copy link
Contributor

Fixes #7876

@loshjawrence can you review?

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse
Copy link
Contributor Author

Test Sandcastle

@lilleyse lilleyse mentioned this pull request May 29, 2019
Closed
@loshjawrence
Copy link
Contributor

loshjawrence commented May 29, 2019 •
edited
Loading

Looks good, will merge when it passes.

@loshjawrence loshjawrence merged commit eece95f into master May 29, 2019
@loshjawrence loshjawrence deleted the fix-credits branch May 29, 2019 18:24
@lilleyse lilleyse mentioned this pull request May 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cesium3D Tilesets credits broken
3 participants
@lilleyse @cesium-concierge @loshjawrence