Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix credits for request render mode #7878

Merged
merged 1 commit into from
May 29, 2019
Merged

Fix credits for request render mode #7878

merged 1 commit into from
May 29, 2019

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented May 29, 2019

Reverts #7877 because of flickering credits in request render mode. Now I remember this was the exact reason why credit updates were moved back into the render pass in 43c0141.

Basically the globe only updates credits in the render pass, not its update pass, so any frames that are skipped by request render mode won't show the credits.

The fix now is to move the 3D Tiles credit update into update rather than postPassesUpdate so that 3D Tiles credits get added within the render pass.

Sancastle - this will show flickery credits in master but not this branch.

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@loshjawrence loshjawrence merged commit 3f34fed into master May 29, 2019
@lilleyse lilleyse deleted the credits-fix-2 branch May 29, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants