Fix credits for request render mode #7878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7877 because of flickering credits in request render mode. Now I remember this was the exact reason why credit updates were moved back into the render pass in 43c0141.
Basically the globe only updates credits in the render pass, not its update pass, so any frames that are skipped by request render mode won't show the credits.
The fix now is to move the 3D Tiles credit update into
update
rather thanpostPassesUpdate
so that 3D Tiles credits get added within the render pass.Sancastle - this will show flickery credits in master but not this branch.