Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce sample data size #8294

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Reduce sample data size #8294

merged 1 commit into from
Oct 24, 2019

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Oct 15, 2019

Fixes #8284

  • Removes unused source model files from Apps/SampleData
  • Hosted the environment map for the Image Based Lighting sandcastle example
  • Better compression for fire.png image used for particle system sandcastle example
  • Resized PNGs for boombox test model used in specs

In total, this reduced the release zip file size from ~92MB to ~52MB

@cesium-concierge
Copy link

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse
Copy link
Contributor

Maybe keep the shadow tester models? They are used in the shadows development sandcastle. At least they aren't too big.

@hpinkos
Copy link
Contributor Author

hpinkos commented Oct 16, 2019

@lilleyse if you ever need them for testing, you can use them on your local machine. I don't see a need to package them up as part of sample data in our library.

@mramato
Copy link
Contributor

mramato commented Oct 18, 2019

I don't see anything wrong with keeping non huge models around in the repository if they are useful for debugging, but that doesn't mean they need to be part of the release zip. Perhaps have a data subdirectory or something under Development Sandcastle examples? This directory is already ignored for release so it will stop the models from being included but still have them available for testing.

@hpinkos
Copy link
Contributor Author

hpinkos commented Oct 21, 2019

Added back the shadow test models. Anything else?

@mramato
Copy link
Contributor

mramato commented Oct 24, 2019

Awesome, thanks @hpinkos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look into why CesiumJS release zip grew significantly larger in the 1.50 release
4 participants