Whole new way of computing a polyline arrow interior. #8793

emackey · 2020-04-23T20:41:40Z

How did I get roped into this? It has nothing to do with anything I'm working on.

Fixes #3491

Possible continued crazy ideas:

Outlines (color + width) would be a good idea to add to this, and would make the arrow head and line pop a little better. Also given this new method, the outline should be able to hold a constant width even around the arrow head and interface with the rest of the line, the same way that fuzz does now. Previously there was a sharply aliased boundary between the head and the line, which is fixed here.
Would be nice someday to add a uniform to control headLength
Would be nice someday to add a uniform to control centerAmount which I guess should be renamed to centerWidth or some such.

Don't try to read this as a line-by-line diff. The whole body has been replaced by new math.

cesium-concierge · 2020-04-23T20:41:44Z

Thanks for the pull request @emackey!

✔️ Signed CLA found.
❔ CHANGES.md was not updated.
- If this change updates the public API in any way, please add a bullet point to CHANGES.md.
❔ Unit tests were not updated.
- Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

Cesium Viewer works.
Works in 2D/CV.
Works (or fails gracefully) in IE11.

mramato · 2020-04-23T22:09:34Z

How did I get roped into this? It has nothing to do with anything I'm working on.

😆 I guess I'm just that charismatic.

emackey · 2020-04-23T23:40:54Z

outlineColor and outlineWidth have been added to the uniforms at the primitive level.

There's a default 1-pixel width black outline. The previous arrow had an unintentional dark blur around it, on account of blending against transparent black. So, the new default looks somewhat similar to the previous effect, except it's crisp and controllable by uniforms.

emackey · 2020-04-24T00:39:43Z

Since outlines work, you can now do hollow arrows.

var viewer = new Cesium.Viewer("cesiumContainer");
var scene = viewer.scene;
var polylines = scene.primitives.add(new Cesium.PolylineCollection());

polylines.add({
  positions: Cesium.Cartesian3.fromDegreesArrayHeights([
    -120.0,
    35.0,
    500000,
    -80.0,
    35.0,
    500000,
  ]),
  width: 80.0,
  material: Cesium.Material.fromType(
    Cesium.Material.PolylineArrowType,{
      color: Cesium.Color.fromAlpha(Cesium.Color.GOLD, 0.3),
      outlineColor: Cesium.Color.GOLD,
      outlineWidth: 4,
    }
  ),
});

mramato · 2020-04-24T00:56:27Z

Looks awesome @emackey the lines are definitely much nicer and crisper.

There are some issues with horizon views and ending up with an arrow head on each side, from your Sandcastle:

emackey · 2020-04-24T00:57:16Z

~~Yep, I believe those are known issues with the way polylines generate their texture coordinates.~~

emackey · 2020-04-24T00:58:37Z

Or maybe it's an artifact of the line being too short for its own head...

emackey · 2020-04-24T01:04:41Z

Well it's... less terrible? CI still running.

mramato · 2020-04-24T03:17:55Z

I’m not seeing the arrow at all on my iPad. I can try desktop Safari tomorrow.

emackey · 2020-04-24T13:53:10Z

The arrow worked on my kids' iPad (Pro or something? 2016-era iPad, I can't keep track of their generations). More testing always welcome.

mramato · 2020-04-24T14:12:13Z

Weird. I tried both my iPhone Xs running 13.4.1 (model MTAL2LL/A) and iPad Pro (10.5 inch) running 13.4.1 (model MQDT2LL/A)

Can anyone else with an iPad/iPhone give a try and confirm if they see the arrow?

emackey · 2020-05-05T13:13:39Z

@shunter Any chance you can test this demo on your iPhone or other iOS gear?

It should look like this:

emackey · 2020-05-05T13:25:54Z

For comparison, here's a similar demo in master (for mobile: standalone demo) with the blurry solid-color arrow.

shunter · 2020-05-05T15:07:34Z

No polyline at all. iPad Air 2 and iPhone 7. I checked the console and there were no related errors (some 404s about missing JS source map files)

cesium-concierge · 2020-06-05T02:00:06Z

Thanks again for your contribution @emackey!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge · 2020-07-05T02:00:06Z

Thanks again for your contribution @emackey!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

emackey · 2020-07-05T18:20:30Z

I'm at a stalemate on this. I presume it's some issue between GLSL and older iOS, but it could be the branch, and I have no hardware that can reproduce it (we have 3 iPads here circa 2017, all show the arrow).

Question: How does the affected hardware handle the arrow in the master branch currently?

If it's not salvageable, feel free to close this.

mramato · 2020-07-06T21:31:50Z

I believe the next version of Safari is getting a new angle-based WebGL backend. So I'm okay with just leaving this open and revisiting as soon as that update is out. I appreciate the effort either way @emackey!

cesium-concierge · 2020-08-06T02:00:08Z

Thanks again for your contribution @emackey!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

# Conflicts: # CHANGES.md

emackey · 2020-08-11T00:09:03Z

Merged master in, just in case #9064 fixed anything here.

mramato · 2020-08-11T15:14:24Z

Thanks @emackey! Unfortunately not. But I still hold out hope the next version of Safari will (since there's a big WebGL overhaul).

I also wonder if there is some undiscovered bug in Cesium that is causing this, (vs the WebGL implementation)

cesium-concierge · 2020-09-11T02:00:10Z

Thanks again for your contribution @emackey!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge · 2020-10-11T02:00:11Z

Thanks again for your contribution @emackey!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge · 2020-11-10T03:00:12Z

Thanks again for your contribution @emackey!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge · 2020-12-10T03:00:14Z

Thanks again for your contribution @emackey!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge · 2021-01-09T03:00:16Z

Thanks again for your contribution @emackey!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

# Conflicts: # CHANGES.md

cesium-concierge · 2021-02-09T03:00:12Z

Thanks again for your contribution @emackey!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge · 2021-03-11T03:00:13Z

Thanks again for your contribution @emackey!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge · 2021-06-09T02:00:18Z

Thanks again for your contribution @emackey!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge · 2021-09-07T02:00:26Z

Thanks again for your contribution @emackey!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge · 2021-12-06T03:00:26Z

Thanks again for your contribution @emackey!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge · 2022-03-06T03:00:15Z

Thanks again for your contribution @emackey!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge · 2022-06-04T02:00:11Z

Thanks again for your contribution @emackey!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

mramato · 2022-06-04T02:13:41Z

I was curious about this PR since Safari is now using ANGLE and has much better WebGL support. I merged in main and the arrow now shows up on iOS. So aspects of this PR is a huge improvement over what's in main. There are still some weird behavior at certain angles that someone might look into, but I feel like this PR is something we can revisit sometimes soon.

nikitakogan · 2022-06-16T13:31:41Z

try to use it on 2D and zoom in to max zoom, its getting destroyed.
this fix is might be relative to 3D Mode.

cesium-concierge · 2022-09-15T02:00:11Z

Thanks again for your contribution @emackey!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge · 2022-12-14T03:00:14Z

Thanks again for your contribution @emackey!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge · 2023-03-14T02:00:17Z

Thanks again for your contribution @emackey!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge · 2023-06-12T02:00:13Z

Thanks again for your contribution @emackey!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

ggetz · 2023-06-12T13:15:49Z

@cesium-concierge stop

ggetz · 2024-02-21T16:18:09Z

I'm closing this for now as it's quite out of date with main. If we wish to revisit this in the future, let's open a fresh PR. Thanks all.

Whole new way of computing a polyline arrow interior.

eb38ff5

Add outlineColor and outlineWidth for polyline arrows.

961e59a

emackey added 2 commits April 23, 2020 20:46

Tweak for machines that lack GL_OES_standard_derivatives

eeeab56

CHANGES.md

baac427

Limit head to not be longer than half the entire length of the line.

a219b4d

emackey marked this pull request as ready for review April 24, 2020 01:16

Update the Development/Polylines Sandcastle demo.

8a94ace

Merge branch 'master' into polyline-arrow-rewrite

03a7ec7

Merge remote-tracking branch 'origin/master' into polyline-arrow-rewrite

67335f6

# Conflicts: # CHANGES.md

emackey added 2 commits January 9, 2021 16:07

Merge remote-tracking branch 'origin/master' into polyline-arrow-rewrite

54dc73d

# Conflicts: # CHANGES.md

Demos

d073574

emackey mentioned this pull request Jan 11, 2021

The arrow of PolylineArrowMaterialProperty is missing #9311

Open

Merge remote-tracking branch 'origin/main' into polyline-arrow-rewrite

f98c458

ggetz mentioned this pull request Jun 16, 2022

Polyline with Arrow Material clamped to ground, the arrow head is choppy/glitchy. #7645

Open

ggetz closed this Feb 21, 2024

Whole new way of computing a polyline arrow interior. #8793

Whole new way of computing a polyline arrow interior. #8793

Conversation

emackey commented Apr 23, 2020 • edited Loading

cesium-concierge commented Apr 23, 2020

mramato commented Apr 23, 2020

emackey commented Apr 23, 2020

emackey commented Apr 24, 2020

mramato commented Apr 24, 2020

emackey commented Apr 24, 2020 • edited Loading

emackey commented Apr 24, 2020

emackey commented Apr 24, 2020

mramato commented Apr 24, 2020

emackey commented Apr 24, 2020

mramato commented Apr 24, 2020

emackey commented May 5, 2020

emackey commented May 5, 2020 • edited Loading

shunter commented May 5, 2020

cesium-concierge commented Jun 5, 2020

cesium-concierge commented Jul 5, 2020

emackey commented Jul 5, 2020 • edited Loading

mramato commented Jul 6, 2020

cesium-concierge commented Aug 6, 2020

emackey commented Aug 11, 2020

mramato commented Aug 11, 2020

cesium-concierge commented Sep 11, 2020

cesium-concierge commented Oct 11, 2020

cesium-concierge commented Nov 10, 2020

cesium-concierge commented Dec 10, 2020

cesium-concierge commented Jan 9, 2021

cesium-concierge commented Feb 9, 2021

cesium-concierge commented Mar 11, 2021

cesium-concierge commented Jun 9, 2021

cesium-concierge commented Sep 7, 2021

cesium-concierge commented Dec 6, 2021

cesium-concierge commented Mar 6, 2022

cesium-concierge commented Jun 4, 2022

mramato commented Jun 4, 2022

nikitakogan commented Jun 16, 2022

cesium-concierge commented Sep 15, 2022

cesium-concierge commented Dec 14, 2022

cesium-concierge commented Mar 14, 2023

cesium-concierge commented Jun 12, 2023

ggetz commented Jun 12, 2023

ggetz commented Feb 21, 2024

emackey commented Apr 23, 2020 •

edited

Loading

emackey commented Apr 24, 2020 •

edited

Loading

emackey commented May 5, 2020 •

edited

Loading

emackey commented Jul 5, 2020 •

edited

Loading