-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: shadowMode cannot apply to i3dm tileset. #9000
Conversation
fix: shadowMode cannot apply to i3dm tileset.
add myself to contributors.
Thanks for the pull request @JiaoJianing!
Reviewers, don't forget to make sure that:
|
Thanks @JiaoJianing - this seems like a pretty straightforward fix. Do you have a sample 3D Tileset you can share that we can use to test this? Easiest way to share it would be to upload it to your Cesium ion account (https://cesium.com/ion/) and share a Sandcastle link here. |
Hi~ @OmarShehata |
@OmarShehata |
@JiaoJianing @OmarShehata it looks like this was actually just fixed in #8981. Back face culling, wireframe, and shadows all had the same problem. This sandcastle should work in master: |
@lilleyse @OmarShehata |
I tried to create a Cesium.Cesium3DTileset with the shadowMode: Cesium.ShadowMode.CAST_ONLY. The tileset contains many trees with i3dm format. But It looks like that shadowMode cannot apply to the tree Model. They will always receive shadow.
I finally find the reason: the shadowMode did not pass to the Model.