Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shadowMode cannot apply to i3dm tileset. #9000

Closed
wants to merge 4 commits into from
Closed

fix: shadowMode cannot apply to i3dm tileset. #9000

wants to merge 4 commits into from

Conversation

JiaoJianing
Copy link
Contributor

I tried to create a Cesium.Cesium3DTileset with the shadowMode: Cesium.ShadowMode.CAST_ONLY. The tileset contains many trees with i3dm format. But It looks like that shadowMode cannot apply to the tree Model. They will always receive shadow.
I finally find the reason: the shadowMode did not pass to the Model.

fix: shadowMode cannot apply to i3dm tileset.
add myself to contributors.
@cesium-concierge
Copy link

Thanks for the pull request @JiaoJianing!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@OmarShehata
Copy link
Contributor

Thanks @JiaoJianing - this seems like a pretty straightforward fix. Do you have a sample 3D Tileset you can share that we can use to test this?

Easiest way to share it would be to upload it to your Cesium ion account (https://cesium.com/ion/) and share a Sandcastle link here.

@JiaoJianing
Copy link
Contributor Author

@OmarShehata
I also found that shadows state of i3dm cannot update dynamic. So I added the update logic in ModelInstanceCollection.prototype.update() to update the _model.shadows.

@JiaoJianing
Copy link
Contributor Author

@lilleyse @OmarShehata
OK! So I will close this PR.

@JiaoJianing JiaoJianing closed this Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants