Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tileset back face culling options #8981

Merged
merged 4 commits into from
Jun 28, 2020
Merged

Tileset back face culling options #8981

merged 4 commits into from
Jun 28, 2020

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Jun 22, 2020 •
edited
Loading

Fixes #8856

Adds tileset.backFaceCulling and model.backFaceCulling options to view a tileset or model from underneath or from inside without having to modify the glTF.

b3dm/i3dm sandcastle
Model sandcastle
Sandcastle in gif

interior

@lilleyse lilleyse requested a review from IanLilleyT June 22, 2020 01:19
@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse lilleyse force-pushed the tileset-back-face-culling branch from 7d73c21 to 074d963 Compare June 22, 2020 01:20
IanLilleyT
IanLilleyT approved these changes Jun 28, 2020
View reviewed changes
Copy link
Contributor

@IanLilleyT IanLilleyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end. In the future it might be possible to simplify the ModelInstanceCollection to not maintain its own DrawCommands and RenderStates and just using the Model's versions directly, but it's not really possible architecturally at the moment.

@IanLilleyT IanLilleyT merged commit 91f7abe into master Jun 28, 2020
@IanLilleyT IanLilleyT deleted the tileset-back-face-culling branch June 28, 2020 16:02
@lilleyse lilleyse mentioned this pull request Jun 30, 2020
Closed
@jo-chemla jo-chemla mentioned this pull request Jul 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanLilleyT IanLilleyT IanLilleyT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Back face culling override for 3D Tiles and models
3 participants
@lilleyse @cesium-concierge @IanLilleyT