Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ModelExperimentalType enum #9990

Merged
merged 3 commits into from
Jan 4, 2022
Merged

Add ModelExperimentalType enum #9990

merged 3 commits into from
Jan 4, 2022

Conversation

ptrgags
Copy link
Contributor

@ptrgags ptrgags commented Jan 3, 2022

Added an enum to label models so we know if it's a single glTF or if it's part of a 3D Tileset (and furthermore if it's a .b3dm, .pnts, .gltf, etc.). This will be useful both in #9978 and #9968

@sanjeetsuhag could you review?

@cesium-concierge
Copy link

Thanks for the pull request @ptrgags!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@ptrgags ptrgags changed the title Add ModelExperimentalType Add ModelExperimentalType enum Jan 3, 2022
@ptrgags
Copy link
Contributor Author

ptrgags commented Jan 4, 2022

@sanjeetsuhag updated! I decided to make ModelExperimentalType private to minimize the API surface area.

Copy link
Contributor

@sanjeetsuhag sanjeetsuhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Thanks @ptrgags!

@sanjeetsuhag sanjeetsuhag merged commit 3e3031d into main Jan 4, 2022
@sanjeetsuhag sanjeetsuhag deleted the model-experimental-type branch January 4, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants