Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle empty external address #70

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

jeluard
Copy link
Contributor

@jeluard jeluard commented Mar 14, 2024

Motivation

Properly support empty external address.

Description

Somme addresses (e.g. 0xA4b06Da12C746666D08e1163CD18Ab57bA544291) trigger error messages when used. Find more context here.
Took this opportunity to introduce some utility functions to improve readability.

@jeluard jeluard requested a review from a team as a code owner March 14, 2024 14:10
@jeluard jeluard requested a review from nazarhussain March 14, 2024 14:10
@nazarhussain nazarhussain merged commit 77747ba into master Mar 18, 2024
4 checks passed
@nazarhussain nazarhussain deleted the jeluard/handle-empty-external-address branch March 18, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants