chore(dot/sync): simplify processBlockData and associated tests
#2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
changed the base branch from
development
to
qdm12/dot/sync/handle-just
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #2811 +/- ##
===============================================
+ Coverage 63.40% 63.47% +0.07%
===============================================
Files 218 218
Lines 27496 27505 +9
===============================================
+ Hits 17434 17460 +26
+ Misses 8461 8442 -19
- Partials 1601 1603 +2 |
qdm12
force-pushed
the
qdm12/dot/sync/handle-just
branch
2 times, most recently
from
ceb798e
to
1d661d6
Compare
qdm12
force-pushed
the
qdm12/dot/sync/handle-just
branch
2 times, most recently
from
793bebc
to
7707152
Compare
qdm12
force-pushed
the
qdm12/dot/sync/processblockdata
branch
2 times, most recently
from
e4d3ce8
to
b3c84a1
Compare
qdm12
commented
Oct 3, 2022
qdm12
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj and
kishansagathiya
as code owners
qdm12
force-pushed
the
qdm12/dot/sync/processblockdata
branch
from
b1dbb04
to
81c1568
Compare
EclesioMeloJunior
requested changes
Oct 4, 2022
qdm12
force-pushed
the
qdm12/dot/sync/processblockdata
branch
from
81c1568
to
755c22c
Compare
qdm12
force-pushed
the
qdm12/dot/sync/processblockdata
branch
from
755c22c
to
b00715a
Compare
q9f
reviewed
Nov 3, 2022
qdm12
force-pushed
the
qdm12/dot/sync/processblockdata
branch
2 times, most recently
from
917f5ca
to
354d4c7
Compare
timwu20
reviewed
Nov 8, 2022
qdm12
force-pushed
the
qdm12/dot/sync/processblockdata
branch
2 times, most recently
from
56ab6ce
to
e2429de
Compare
qdm12
force-pushed
the
qdm12/dot/sync/processblockdata
branch
from
e2429de
to
8c5bac2
Compare
timwu20
approved these changes
Nov 14, 2022
qdm12
force-pushed
the
qdm12/dot/sync/processblockdata
branch
from
8c5bac2
to
eab9165
Compare
qdm12
force-pushed
the
qdm12/dot/sync/processblockdata
branch
from
eab9165
to
2de6f19
Compare
edwardmack
approved these changes
Nov 15, 2022
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
processBlockData:processBlockDataWithHeaderAndBodyfunction with testprocessBlockDataWithStateHeaderAndBodyfunction with testblockDataas value argument instead of pointerstocforchainProcessorprocessBlockData(now covered in subfunctions associated tests)handleJustification.Done whilst fixing tests in #2774
🆕 is kinda blocking me on #2912 (trying to fix the memmm)
Tests
go test -tags integration github.com/ChainSafe/gossamer/dot/syncIssues
Primary Reviewer
@edwardmack