Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dot/sync): simplify processBlockData and associated tests #2811

Merged
merged 21 commits into from
Nov 15, 2022
Merged

chore(dot/sync): simplify processBlockData and associated tests #2811

merged 21 commits into from
Nov 15, 2022

Commits on Nov 15, 2022

  1. Remove nil header and justification check

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    3e72ee9 View commit details
    Browse the repository at this point in the history

  2. Remove block data nil check

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    2ae2a4b View commit details
    Browse the repository at this point in the history

  3. Review error wrappings

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    6c8a81f View commit details
    Browse the repository at this point in the history

  4. Remove unneeded duplicate logs

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    3fbbf47 View commit details
    Browse the repository at this point in the history

  5. Move debug log in handleJustification

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    818eac0 View commit details
    Browse the repository at this point in the history

  6. Return error on block import error

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    6e0d4b1 View commit details
    Browse the repository at this point in the history

  7. Fix place of skip debug log

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    41fa64d View commit details
    Browse the repository at this point in the history

  8. Fix place of another debug log

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    fb759de View commit details
    Browse the repository at this point in the history

  9. processBlockDataWithStateHeaderAndBody function

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    78b4492 View commit details
    Browse the repository at this point in the history

  10. processBlockDataWithHeaderAndBody function

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    2d5b96a View commit details
    Browse the repository at this point in the history

  11. processBlockData takes block data as value arg

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    f7037b2 View commit details
    Browse the repository at this point in the history

  12. processBlockData receiver s -> c

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    b16a54d View commit details
    Browse the repository at this point in the history

  13. Rename bd argument to blockData

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    a49eb1d View commit details
    Browse the repository at this point in the history

  14. Test_chainProcessor_processBlockDataWithStateHeaderAndBody

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    4c894a4 View commit details
    Browse the repository at this point in the history

  15. Test_chainProcessor_processBlockDataWithHeaderAndBody

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    5f6c74e View commit details
    Browse the repository at this point in the history

  16. Remove coverage-unneeded test cases

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    2f77372 View commit details
    Browse the repository at this point in the history

  17. Re-add justification length check

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    d23f498 View commit details
    Browse the repository at this point in the history

  18. Apply PR feedback

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    fd3e2c2 View commit details
    Browse the repository at this point in the history

  19. Change pop to return an error on context cancelation

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    7552abe View commit details
    Browse the repository at this point in the history

  20. Fix //nolint directives

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    d30b700 View commit details
    Browse the repository at this point in the history

  21. Merge if blocks in single blockData.Header != nil if block

    @qdm12
    qdm12 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    2de6f19 View commit details
    Browse the repository at this point in the history