feat: add iwant request tracking #107
Conversation
wemeetagain
force-pushed
the
cayman/gs1.1-iwant-penalties
branch
from
2beb0c7
to
b3942e4
Compare
Codecov Report
@@ Coverage Diff @@
## gsv1.1 #107 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 2 2
Lines 24 24
=======================================
Hits 22 22
Misses 2 2
Continue to review full report at Codecov.
|
|
|
||
| /** | ||
| * Someone delivered a message, stop tracking promises for it | ||
| * @param {string} p peer id |
There was a problem hiding this comment.
It seems that we are not using the peerID
There was a problem hiding this comment.
The idea is to have the same function signature as PeerScore#deliverMessage.
So that we might in the future abstract the different 'tracers' as in go-libp2p-pubsub
See https://github.com/libp2p/go-libp2p-pubsub/blob/master/pubsub.go#L972
Eg: they don't call each one individually:
this.score.deliverMessage(p, msg)
this.gossipTracer.deliverMessage(p, msg)
this.tagTracer.deliverMessage(p, msg)
They have some sort of registration for each of their tracers, then all tracers get called on a single call to deliverMessage.
Note the go-libp2p-pubsub tracer functionality is happening on the pubsub layer, not the gossipsub layer. Aggregating our "tracers" together would be a first step towards moving in that direction. Not saying thats what we should do, but aligning function signatures is a prereq.
Implements https://github.com/libp2p/specs/blob/master/pubsub/gossipsub/gossipsub-v1.1.md#spam-protection-measures bullet point 4
Follows go-libp2p-pubsub implementation closely
Suffers from issues related to #105
eg: in cases where a peer has signaled that they IHAVE a message, we send a IWANT, they send the message, but don't include a signature on a message when we have strict signing, the peer should be penalized twice, once for the invalid message, and once more if they fail to deliver on their promise to send the IWANTed message.
Right now, they only get the first penalty, from the invalid message.