Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pr template #2013

Merged
merged 13 commits into from
Mar 14, 2022
Merged

Update pr template #2013

merged 13 commits into from
Mar 14, 2022

Conversation

asnaith
Copy link
Member

@asnaith asnaith commented Mar 10, 2022

Added a new check to prompt us about billing changes being applied to both Files and Storage.

@asnaith asnaith requested review from tanmoyAtb and FSM1 March 10, 2022 21:31
@render
Copy link

render bot commented Mar 10, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-2013.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8l6sif6d9kqnpondtag.

@render
Copy link

render bot commented Mar 10, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-2013.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8l6siv6d9kqnpondtf0.

@render
Copy link

render bot commented Mar 10, 2022

Your Render PR Server URL is https://files-ui-stage-pr-2013.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8l6sjf6d9kqnpondtsg.

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Mar 10, 2022
@asnaith
Copy link
Member Author

asnaith commented Mar 11, 2022

I'm not sure how I upset the code analysis with such a small change, I followed the same indentation 😅. I'll look again tomorrow.

@asnaith
Copy link
Member Author

asnaith commented Mar 12, 2022

Codacy seems to be failing with two (incorrect?) warnings on the markdown file.

I have experimented with their suggested way to ignore files and added a codacy.yml config at the root to exclude the .github directory but it didn't work.

Does anyone have any suggestions to suppress these warnings?

Tbaut
Tbaut reviewed Mar 14, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's drunk, let's re-run it

.github/pull_request_template.md Outdated Show resolved Hide resolved
@Tbaut Tbaut enabled auto-merge (squash) March 14, 2022 11:59
Tbaut
Tbaut approved these changes Mar 14, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now :)

edit: erm no

@Tbaut
Copy link
Collaborator

Tbaut commented Mar 14, 2022 •
edited
Loading

I deactivated those warnings on codacy directly, they are 100% not helpful and wrong IMO

@Tbaut Tbaut merged commit 79a45af into dev Mar 14, 2022
@Tbaut Tbaut deleted the mnt/update-pr-template branch March 14, 2022 14:57
@asnaith
Copy link
Member Author

asnaith commented Mar 15, 2022

@Tbaut Thanks for taking care of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FSM1 FSM1 FSM1 approved these changes

@Tbaut Tbaut Tbaut approved these changes

@tanmoyAtb tanmoyAtb Awaiting requested review from tanmoyAtb

Assignees
No one assigned
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asnaith @Tbaut @FSM1