Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pr template #2013

Merged
merged 13 commits into from
Mar 14, 2022
Merged

Update pr template #2013

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
67ab08e
Update pr template
asnaith Mar 10, 2022
4b123ef
fix warning
asnaith Mar 11, 2022
c02f92f
remove warning with compliant indentation?
asnaith Mar 11, 2022
3e54a6d
thank goodness these get squashed
asnaith Mar 11, 2022
23c0076
is this it?
asnaith Mar 11, 2022
164d320
minor change
asnaith Mar 11, 2022
f7d2554
ignore github config directory for code analysis
asnaith Mar 11, 2022
51d6f1d
Revert "ignore github config directory for code analysis"
asnaith Mar 11, 2022
301d868
ignore github config directory for codacy
asnaith Mar 12, 2022
c1fe436
move codacy configuration to root
asnaith Mar 12, 2022
04abc81
remove codacy configuration
asnaith Mar 12, 2022
ce557e3
Update .github/pull_request_template.md
Tbaut Mar 14, 2022
68e11eb
Merge branch 'dev' into mnt/update-pr-template
Tbaut Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,9 @@ Submission checklist:
- [ ] Change looks good in the mobile web ui

#### Theme
- [ ] Components / elements inspected in light mode
- [ ] Components / elements inspected in dark mode
- [ ] Components / elements inspected in light mode
- [ ] Components / elements inspected in dark mode

#### Billing
- [ ] Change applied to both files-ui and storage-ui