Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: oEmbed implementation #139

Merged
merged 20 commits into from
May 24, 2021
Merged

feat: oEmbed implementation #139

Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
816ac5e
feat: initial oEmbed implementation
KararTY May 2, 2021
25748b9
Provide a 'default' list of providers
pajlada May 9, 2021
58dac2a
Add the option to change path where to find the providers.json file
pajlada May 9, 2021
7d2365b
Since we provide our own `providers.json`, remove `excludedHosts` logic
pajlada May 9, 2021
a7279f6
remove some bad oembed providers
pajlada May 9, 2021
ea8cce9
Add support for rich facebook/instagram oEmbed using the `CHATTERINO_…
pajlada May 9, 2021
d9d8a46
Add changelog entry
pajlada May 9, 2021
b8d9a7a
Add readme page for the oEmbed resolver package
pajlada May 9, 2021
59d5b1e
Update internal/resolvers/oembed/load.go
KararTY May 17, 2021
d46cacd
Update internal/resolvers/oembed/load.go
KararTY May 17, 2021
e554ca7
Update internal/resolvers/oembed/load.go
KararTY May 17, 2021
7bca0ff
fix: resolve requested changes
KararTY May 17, 2021
78d621d
fix: resolve requested changes
KararTY May 17, 2021
8444928
docs: Refer users to the README for oEmbed
KararTY May 17, 2021
4882c0f
docs: Add apiKeys explanation.
KararTY May 17, 2021
605bfcc
Merge branch 'master' into feature-oembed
KararTY May 17, 2021
4079882
xd
KararTY May 17, 2021
542e9a7
fix: Log missing environment variables
KararTY May 17, 2021
a06f3a4
fix: woops
KararTY May 17, 2021
8fea7b0
Merge branch 'master' into feature-oembed
pajlada May 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Unreleased

- Added support for customizable oEmbed resolving for websites with the `resolvers.json` file. See [`data/oembed/resolvers.json`](data/oembed/resolvers.json). Three new environment variables can be set. See [`internal/resolvers/oembed/README.md`](internal/resolvers/oembed/README.md) (#139)
- Breaking: Environment variable `CHATTERINO_API_CACHE_TWITCH_CLIENT_ID` was renamed to `CHATTERINO_API_TWITCH_CLIENT_ID`. (#144)
- Dev, Breaking: Replaced `dankeroni/gotwitch` with `nicklaw5/helix`. This change requires you to add new environment variable: `CHATTERINO_API_TWITCH_CLIENT_SECRET` - it's a client secret generated for your Twitch application.

Expand Down
13 changes: 13 additions & 0 deletions data/oembed/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# providers.json

Original source: <https://oembed.com/providers.json> (2021-05-09)

## Removed providers

- Kickstarter because its oembed provides less data than using opengrah values
- Reddit because its oembed provides less data than using opengraph values
- Spotify because its oembed provides less data than using opengraph values
- Twitter because we have a rich resolver already
- YouTube because we have a rich resolver already

And a few more that can be diffed between <https://oembed.com/providers.json> and our [providers.json](data/provider.json) file
Loading