-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: oEmbed implementation #139
Conversation
Quick overview: https://oembed.com/ |
…API_OEMBED_FACEBOOK_APP_ID` and `CHATTERINO_API_OEMBED_FACEBOOK_APP_SECRET` environment variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
For future reference's sake:
|
Co-authored-by: Paweł <zneix@zneix.eu>
Co-authored-by: Paweł <zneix@zneix.eu>
Co-authored-by: Paweł <zneix@zneix.eu>
Does it need to be this verbose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's all fine unless I've missed something.
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
Old stuff
Unfinished, I feel like this needs more thought put into it.
Should we do it this way?
Should we handle each oEmbed separately maybe?
Lacking:
Custom resolvers for some services like Instagram (Needs a token).
Some services are not in the providers file, instead they offer a "discovery" url in their HTML document metafields, this has to be implemented somehow.
Features:
resolvers.json
file.Full original providers file (Chatterino/api comes with its own modified file):
https://oembed.com/providers.json