Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oEmbed implementation #139

Merged
merged 20 commits into from
May 24, 2021
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Unreleased

- Support for oEmbed resolving for websites customizable with the `resolvers.json` file. See `data/oembed/resolvers.json`. (#139)
KararTY marked this conversation as resolved.
Show resolved Hide resolved
- Breaking: Environment variable `CHATTERINO_API_CACHE_TWITCH_CLIENT_ID` was renamed to `CHATTERINO_API_TWITCH_CLIENT_ID`. (#144)
- Dev, Breaking: Replaced `dankeroni/gotwitch` with `nicklaw5/helix`. This change requires you to add new environment variable: `CHATTERINO_API_TWITCH_CLIENT_SECRET` - it's a client secret generated for your Twitch application.

Expand Down
13 changes: 13 additions & 0 deletions data/oembed/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# providers.json

Original source: https://oembed.com/providers.json (2021-05-09)

## Removed providers:

- Kickstarter because its oembed provides less data than using opengrah values
- Reddit because its oembed provides less data than using opengraph values
- Spotify because its oembed provides less data than using opengraph values
- Twitter because we have a rich resolver already
- YouTube because we have a rich resolver already

And a few more that can be diffed between https://oembed.com/providers.json and our providers.json file
Loading