Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a mistake when adding languages #8

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

yuu1111
Copy link

@yuu1111 yuu1111 commented Jul 1, 2024

  • Japanese was not added to verifyLang() in `utils.ts

  • Add break; to SettingsDisplayUiHandler() in settings-display-ui-handler.ts, because it was missing in the Switch statement (fix for the problem that Language in the settings screen was still displayed in English)

  • I should also add Japanese processing to battle-stat.test.ts, but I don't know what it does, so I haven't made any changes this time.

Machine translation from Japanese to English.

…handler.ts`, because it was missing in the Switch statement (fix for the problem that Language in the settings screen was still displayed in English)
@OrangeRed
Copy link

こんばんは、

最後の人 @Chepyu がどこに行ったわからないんですが、あの方のフォークをコピーして新しい PRを作りました。

できれば @yuu1111 が今までしたことを俺のフォークで移動してくれませんか?

Comment on lines +457 to 459
case "ja":
return true;
default:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case "ja":
return true;
default:
return true;
case "ja":
default:

verifylang() needs public/images/types_ja.png and types_ja.json.
Setting return value to false is now better, until type images are added.

Copy link

@MrWaterT MrWaterT Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+ battle-stat.test.ts is for npm test, checking locales/ja/pokemon-info.ts and locale/ja/battle.ts.

@Chepyu Chepyu merged commit 3027263 into Chepyu:translate-jp Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants