disable vertical scroll instead of hide on desktop browsers #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigelk
changed the title
rigelk
previously requested changes
Jul 15, 2020
kimsible
force-pushed
the
fix/disable-scroll-instead-of-hide
branch
from
a3acec1
to
f26a9a8
Compare
kimsible
force-pushed
the
fix/disable-scroll-instead-of-hide
branch
from
f26a9a8
to
6d1a2b8
Compare
rigelk
dismissed
their stale review
changes made, but manual testing required before final approval
|
Tested and happy with the result. Thanks @kimsible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR which is more a visual fix.
It improves UX/UI nav transitions on desktop browsers where the vertical scrollbar is not floating over the body like touch devices do.
Now, when switching from a vertical scrolled content to a non-scrolled content / opened modal view, the vertical scroll will be disabled instead of hide on desktop browsers.
This way, header (upload button and search input) and content won't be involuntarily moved horizontally to the right.