Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable vertical scroll instead of hide on desktop browsers #2962

Merged
merged 1 commit into from
Jul 23, 2020
Merged

disable vertical scroll instead of hide on desktop browsers #2962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions client/src/sass/application.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ body {
color: pvar(--mainForegroundColor);
background-color: pvar(--mainBackgroundColor);
font-size: 14px;
// On desktop browsers, make sure vertical scroll bar is always visible
// Allow to disable the scrollbar instead of hide it when the content fit the body
// And not move the content and header horizontally sticked to right when the content is updating
overflow-y: scroll;
}

::selection {
Expand Down
8 changes: 8 additions & 0 deletions client/src/sass/bootstrap.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,14 @@ $icon-font-path: '~@neos21/bootstrap3-glyphicons/assets/fonts/';
}
}


// On desktop browsers, make the content and header horizontally sticked to right not move when modal open and close
.modal-open {
overflow-y: scroll !important; // Make sure vertical scroll bar is always visible on desktop browsers to get disabled scrollbar effect
position: fixed; // Fix the body position to disable any scroll content
width: 100vw; // Make sure the content fits all the available width when position: fixed
}

// Nav customizations
.nav .nav-link {
display: flex !important;
Expand Down