Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note about GDAL building issues on Windows #238

Closed
wants to merge 1 commit into from
Closed

Conversation

vlandau
Copy link
Member

@vlandau vlandau commented Jun 9, 2020

Some Omniscape users had this problem. Just thought I'd add text to provide some guidance. See Circuitscape/Omniscape.jl/issues/47

@vlandau
Copy link
Member Author

vlandau commented Jun 9, 2020

@ranjanan please merge if it looks okay -- just a simple addition to the readme.

@coveralls
Copy link

coveralls commented Jun 9, 2020

Pull Request Test Coverage Report for Build 647

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.471%

Totals Coverage Status
Change from base Build 645: 0.0%
Covered Lines: 1553
Relevant Lines: 1817

💛 - Coveralls

@ViralBShah
Copy link
Member

My suggestion is that we just wait for GDAL.jl folks to tag a new version and update our dependencies.

@vlandau
Copy link
Member Author

vlandau commented Jun 9, 2020

My suggestion is that we just wait for GDAL.jl folks to tag a new version and update our dependencies.

Okay -- We don't have a compat entry for GDAL since we depend on ArchGDAL (which of course itself depends on GDAL), but I think this is solved with ArchGDAL v0.4.0 which was just released. See yeesian/ArchGDAL.jl#125

I added v0.4 to the compat, but we could also remove ArchGDAL of 0.3.1 to prevent this issue altogether.

@ViralBShah
Copy link
Member

Let's keep moving forward on versions.

@vlandau
Copy link
Member Author

vlandau commented Jun 9, 2020

I'll close this. I can do direct commit to master to update the ArchGDAL compat if that works?

@vlandau vlandau closed this Jun 9, 2020
@vlandau
Copy link
Member Author

vlandau commented Jun 10, 2020

I think we just need to change the compat to v0.4.0 for ArchGDAL.

@ViralBShah
Copy link
Member

I just realized my comment was wrong and deleted it. Yes, we should do that - so that we are able to use artifacts.

@vlandau
Copy link
Member Author

vlandau commented Jun 10, 2020

Okay I'll make that commit now!

@vlandau
Copy link
Member Author

vlandau commented Jun 10, 2020

Ha! You beat me to it 🙂

@ViralBShah
Copy link
Member

:-) I also updated IterativeSolvers.jl. Seems to pass things for me - but can you give it a try?

I think these old versions were holding back many dependencies to old versions. This should resolve more dependent packages to use newer versions.

@ViralBShah
Copy link
Member

Just bumped AlgebraicMultigrid too.

@vlandau
Copy link
Member Author

vlandau commented Jun 10, 2020

Install working fine on my Linux machine 👍

@ViralBShah
Copy link
Member

Let's give it a few days on master and then tag a new version. Do the omniscape tests pass with this?

@vlandau
Copy link
Member Author

vlandau commented Jun 10, 2020

I'll test it out now!

@ViralBShah ViralBShah deleted the vl/readme branch June 10, 2020 23:29
@vlandau
Copy link
Member Author

vlandau commented Jun 10, 2020

Ah, we changed RasterMeta internally in Circuitscape so I just need to make a slight update. I'm going to update the Circuitscape dep to 5.6.0 soon,too, and switch to the CS versions of read_raster and write_raster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants