Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require julia 1.3 / GDAL build with artifacts #125

Merged
merged 2 commits into from
Jun 4, 2020
Merged

require julia 1.3 / GDAL build with artifacts #125

merged 2 commits into from
Jun 4, 2020

Conversation

evetion
Copy link
Collaborator

@evetion evetion commented Jun 4, 2020

To always make use of the new GDAL build system (jll). Should make support easier but bumps our Julia version from LTS to 1.3.

To always make use of the new GDAL build system (jll). Should make support easier but bumps our Julia version from LTS to 1.3.
@evetion evetion requested a review from visr June 4, 2020 12:42
@coveralls
Copy link

coveralls commented Jun 4, 2020

Coverage Status

Coverage increased (+1.3%) to 92.637% when pulling 6faf231 on bump-gdal into 5fce0c1 on master.

@visr
Copy link
Collaborator

visr commented Jun 4, 2020

Yeah I think this would be good to add. I somehow regularly still end up with GDAL.jl 1.0 (pre jll) if I add ArchGDAL. And that build is much more broken than the jll. Requiring this version and perhaps retrocapping older versions should help there.

This PR still needs updating of the versions tested in CI. Coul you also remove the VERSION check from #108 and perhaps any others that may be present?

Copy link
Collaborator

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@visr visr changed the title Update Project.toml require julia 1.3 / GDAL build with artifacts Jun 4, 2020
@evetion evetion merged commit 29c824b into master Jun 4, 2020
@visr visr deleted the bump-gdal branch June 4, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants