fix: the server selector types provide the correct comparators #1111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The server selector types were not sorting how they are supposed to. The HIGHEST_PLAYERS comparator would sort for the lowerst players and vice-versa.
Modification
Inverted the comparison order by switching the comparator of the HIGHEST_PLAYERS to the LOWEST_PLAYERS and using Comparator#reversed
Result
The comparators provide the correct comparison result