New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace libopen's GPIO APIS by Zephyr GPIO APIs #3

Merged

ikerperezdelpalomar merged 13 commits into main from GPIO_APIs

Jul 7, 2021

Collaborator

ikerperezdelpalomar commented Apr 12, 2021 •

edited

Loading

This merge request replaces libopens GPIO;s APIs with Zephyr's GPIO API's.
Tested functions:

skirkham reviewed

View reviewed changes

src/led.c Outdated Show resolved Hide resolved

skirkham reviewed

View reviewed changes

src/led.c Outdated Show resolved Hide resolved

skirkham reviewed

View reviewed changes

src/led.c Outdated Show resolved Hide resolved

skirkham reviewed

View reviewed changes

src/led.c Outdated Show resolved Hide resolved

skirkham reviewed

View reviewed changes

src/led.c Outdated Show resolved Hide resolved

ikerperezdelpalomar force-pushed the GPIO_APIs branch 2 times, most recently from a9941ce to e7a5d7a Compare

April 30, 2021 10:22

Collaborator Author

ikerperezdelpalomar commented May 19, 2021

Zephyr has stopped configuring clock from the code and instead is doing it from device tree. Should I implement this in this pull request or should we work on this separately?

ikerperezdelpalomar force-pushed the GPIO_APIs branch 3 times, most recently from 9244a81 to 01b3ce2 Compare

May 25, 2021 11:12

Collaborator

rdale commented May 25, 2021

Can you please not add 'Signed-off-by:' lines to the commit messages. It doesn't make any sense for the project at this stage.

rdale reviewed

View reviewed changes

src/led.c Outdated Show resolved Hide resolved

rdale reviewed

View reviewed changes

src/acq/channel.h Outdated Show resolved Hide resolved

rdale reviewed

View reviewed changes

src/led.c Outdated Show resolved Hide resolved

rdale reviewed

View reviewed changes

tests/led/CMakeLists.txt

@@ @@ -15,6 +15,6 @@ zephyr_include_directories(${CMAKE_SOURCE_DIR}/../..) @@
               project(led_test)
               target_sources(app PRIVATE
-                  main.c
+                  bloodlight_based.c

Collaborator

rdale May 25, 2021

It isn't clear why you have renamed 'main.c' as 'bloodlight_based.c'. The intended meaning of the name 'bloodlight based' isn't very clear.

Collaborator Author

ikerperezdelpalomar Jun 1, 2021

I edited the commit description. See: 8afe0b7

rdale reviewed

View reviewed changes

tests/led/bloodlight_based.c Outdated

+              #include <drivers/uart.h>
+              #include "../../src/led.h"
+              #include "../../src/led.c"

Collaborator

rdale May 25, 2021

The project should have 'led.c' in the target_sources() in the CMakeLists.txt file and there is not need to include the sources like this. Also 'led.c' will have an include for 'led.h' and you wouldn't need two includes if you to include the 'led.c' source like this.

Collaborator Author

ikerperezdelpalomar Jun 1, 2021

why is it that by including led.c in target_sources() I don need to include it in bloodlight_based.c?

rdale reviewed

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

ikerperezdelpalomar force-pushed the GPIO_APIs branch from 01b3ce2 to 46ef867 Compare

May 27, 2021 11:29

Collaborator Author

ikerperezdelpalomar commented Jun 1, 2021

Can you please not add 'Signed-off-by:' lines to the commit messages. It doesn't make any sense for the project at this stage.

It is my personal preference to sign all my commits, as it won't hurt in any way the project I will keep doing it.

ikerperezdelpalomar force-pushed the GPIO_APIs branch from b924ae2 to 8cc986d Compare

June 1, 2021 09:05

ikerperezdelpalomar force-pushed the GPIO_APIs branch from 53cf0f3 to 6f78e52 Compare

June 9, 2021 12:45

ikerperezdelpalomar linked an issue

that may be closed by this pull request

Make LEDs work #7

Closed

4 tasks

ikerperezdelpalomar force-pushed the GPIO_APIs branch 4 times, most recently from 7380329 to 7dcb0de Compare

June 10, 2021 11:48

ikerperezdelpalomar mentioned this pull request

Add in USB code #8

Open

4 tasks

ikerperezdelpalomar added the Pending Review label

ikerperezdelpalomar force-pushed the GPIO_APIs branch 2 times, most recently from 55354f1 to a62352b Compare

June 29, 2021 07:06

ikerperezdelpalomar linked an issue

that may be closed by this pull request

Zephyr ztest for LEDs #16

Open

ikerperezdelpalomar removed the Pending Review label

ikerperezdelpalomar force-pushed the GPIO_APIs branch from 0c12b8e to d3a422d Compare

July 7, 2021 08:29

Iker Perez del Palomar Sustatxa added 12 commits

July 7, 2021 09:30


          led.c: Implement Zephyrs GPIO APIs

e991fe0

Signed-off-by: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>


          led.c: Replace RCC APIs

b1cac8f

Signed-off-by: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>


          channel.h and led.c: Fix header paths

7b2f561

Signed-off-by: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>


          led.c: Remove building hack

d1a5a1f

Signed-off-by: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>


          led.c:bl_led__gpio_mode_setup(): Configure all ports and pins in one go.

750ac10

Configure inside bl_led__gpio_mode_setup() all pins containing a LED
connected to them on each port.

Signed-off-by: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>


          led.c/led.h/spi.c: Make gpio_binding() public and use it in spi.c

02182ea

This ensures that bl_led_get_port() can be used in spi.c

Signed-off-by: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>


          CMakeLists.txt: Add board revision flag

e47c0ae

Signed-off-by: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>


          bloodlight_based.c: Create test for led.c

31723c8

* Include console support
* Bloodlight_based.c: Test leds with led.c APIs.
* Build bloodlight_based.c by default.
* Test bl_led_status_set()

Keep both tests zephyr_based (previous main) and bloodlight_based.c so
the user can select in CMakeFie which test wants to run. zephyr_based to
test leds using zephyrs APIs or bloodlight_based to test them using
bloodlight's APIs.

Signed-off-by: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>


          bloodlight_based.c: Test bl_led_set()

f06f3c3

Signed-off-by: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>


          bloodlight_based.c: Test bl_led_get_port()

149dee4

Signed-off-by: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>


          bloodlight_based: Add assertions to bl_led_get_gpio and printfs

7d00809

Signed-off-by: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>


          bloodlight_based.c: Reorganice includes

fa33bb8

Signed-off-by: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>

ikerperezdelpalomar force-pushed the GPIO_APIs branch from d3a422d to fa33bb8 Compare

July 7, 2021 08:30


          Merge branch 'main' into GPIO_APIs

16d085d

ikerperezdelpalomar merged commit c8fc807 into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet