Skip to content

Commit

Permalink
[native] Bump Android target SDK version to 34
Browse files Browse the repository at this point in the history
Summary:
This addresses [ENG-8812](https://linear.app/comm/issue/ENG-8812/update-android-target-api). We need to bump this in order to continue submitting new versions of the Comm Android app to the Play Store.

Depends on D13250

Test Plan:
1. CI and tested running the Android app on simulator. Before releasing this I'll test a release build on a physical Android device and play around with it a bit
2. `cd native && git grep 33` and review all results

Reviewers: varun, will, marcin

Reviewed By: varun

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D13251
  • Loading branch information
Ashoat committed Sep 5, 2024
1 parent 87fee3d commit 61f2796
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions native/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

buildscript {
ext {
buildToolsVersion = "33.0.0"
buildToolsVersion = "34.0.0"
minSdkVersion = 23
compileSdkVersion = 33
targetSdkVersion = 33
compileSdkVersion = 34
targetSdkVersion = 34
if (System.properties['os.arch'] == "aarch64") {
// For M1 Users we need to use the NDK 24 which added support for aarch64
ndkVersion = "24.0.8215888"
Expand Down
4 changes: 2 additions & 2 deletions native/expo-modules/comm-expo-package/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ afterEvaluate {
}

android {
compileSdkVersion safeExtGet("compileSdkVersion", 33)
compileSdkVersion safeExtGet("compileSdkVersion", 34)

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand All @@ -72,7 +72,7 @@ android {

defaultConfig {
minSdkVersion safeExtGet("minSdkVersion", 23)
targetSdkVersion safeExtGet("targetSdkVersion", 33)
targetSdkVersion safeExtGet("targetSdkVersion", 34)
versionCode 1
versionName "0.1.0"
}
Expand Down

0 comments on commit 61f2796

Please sign in to comment.