Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fix Source Link #633

Closed
wants to merge 3 commits into from
Closed

Try fix Source Link #633

wants to merge 3 commits into from

Conversation

jfversluis
Copy link
Member

No description provided.

@jfversluis jfversluis marked this pull request as draft September 16, 2022 08:56
@jfversluis
Copy link
Member Author

Hm I see no change in the build artifacts. I guess they should contain the pdb files as well for this to work?

@pictos
Copy link
Member

pictos commented Sep 16, 2022

The NuGet looks healthy
image

@jfversluis
Copy link
Member Author

Yeah I'm worried that this browser might not tell the full story here. If I download the artifact I still don't see any PDB files in there. Also not sure if that's supposed to be the case. I'd hate for this to be dragging on and it's only something we can test when actually publishing NuGet packages to a feed...

@marcmognol
Copy link
Contributor

Hi @jfversluis
Is there any reason not using Dotnet.ReproducibleBuilds package ?

https://github.com/dotnet/reproducible-builds

@jfversluis
Copy link
Member Author

@marcmognol
Copy link
Contributor

😁 yes !

@VladislavAntonyuk
Copy link
Collaborator

VladislavAntonyuk commented Oct 13, 2022

It is fixed in .NET 7:
I created a PR with migration to.NET 7: #681

@jfversluis
Copy link
Member Author

OK, so I think we have established that Source Link works according to @kphillpotts and the error then goes away with .NET 7. So let's just wait for that then.

@jfversluis jfversluis closed this Oct 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants