Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare to .NET 7 release #681

Merged
merged 13 commits into from
Nov 9, 2022
Merged

Prepare to .NET 7 release #681

merged 13 commits into from
Nov 9, 2022

Conversation

VladislavAntonyuk
Copy link
Collaborator

Description of Change

Linked Issues

PR Checklist

Additional information

@VladislavAntonyuk VladislavAntonyuk added the hacktoberfest-accepted A PR that has been approved during Hacktoberfest label Oct 7, 2022
@VladislavAntonyuk VladislavAntonyuk added this to the vNext milestone Oct 7, 2022
@VladislavAntonyuk VladislavAntonyuk self-assigned this Oct 7, 2022
@VladislavAntonyuk VladislavAntonyuk requested review from brminnick, pictos and a team and removed request for brminnick and pictos October 7, 2022 13:38
@VladislavAntonyuk VladislavAntonyuk mentioned this pull request Oct 13, 2022
Closed
brminnick
brminnick reviewed Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good Vlad! I just have some thoughts on our CI pipeline, but the rest of the code updates look good!

azure-pipelines.yml Outdated Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
samples/CommunityToolkit.Maui.Sample/AppShell.xaml Show resolved Hide resolved
src/CommunityToolkit.Maui/Alerts/Snackbar/Snackbar.android.cs Show resolved Hide resolved
src/CommunityToolkit.Maui/Alerts/Snackbar/Snackbar.android.cs Show resolved Hide resolved
@brminnick brminnick mentioned this pull request Oct 21, 2022
Merged
6 tasks
@VladislavAntonyuk VladislavAntonyuk added the needs discussion Discuss it on the next Monthly standup label Nov 1, 2022
@brminnick brminnick modified the milestones: vNext, v3.0.0 Nov 3, 2022
@VladislavAntonyuk VladislavAntonyuk removed the needs discussion Discuss it on the next Monthly standup label Nov 7, 2022
@rjygraham
Copy link
Contributor

Is this going to be completed for .NET 7 release tomorrow?

@brminnick
Copy link
Collaborator

Yup! The plan is to merge this PR as soon as the .NET MAUI team releases their stable SDKs targeting .NET 7, then publish a new release to NuGet 💯

@VladislavAntonyuk VladislavAntonyuk enabled auto-merge (squash) November 9, 2022 09:50
@VladislavAntonyuk VladislavAntonyuk merged commit 5520122 into main Nov 9, 2022
@VladislavAntonyuk VladislavAntonyuk deleted the net7.0-preparation branch November 9, 2022 09:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoonghyunCho JoonghyunCho JoonghyunCho approved these changes

@brminnick brminnick brminnick approved these changes

Assignees

@VladislavAntonyuk VladislavAntonyuk

Labels
hacktoberfest-accepted A PR that has been approved during Hacktoberfest
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

[BUG] Adding animation crashes app in .NET 7 RC1
4 participants
@VladislavAntonyuk @rjygraham @brminnick @JoonghyunCho