Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization #7

Closed
wants to merge 13 commits into from
Closed

Conversation

maxkoshevoi
Copy link
Contributor

Related issues

What was done

  • Migrated localization classes and classes they depend on, along with their test.

Notes

  • There may be some overlap with windows toolkit (I'm sure that ObservableObject is already there). Those classes will need to be removed from here when common package is created.

@pictos
Copy link
Member

pictos commented Jul 30, 2021

Hey there, please wait until we define what we will migrate to this repo and how. If I'm not wrong this repo isn't even with the XCT

@brminnick
Copy link
Collaborator

Hi Max! We are not bringing WeakEventManager nor ObservableObject to the Maui Community Toolkit.

We will be leveraging + recommending the Microsoft.Toolkit.Mvvm NuGet package (soon to be renamed CommunityToolkit.Mvvm) for all MVVM tooling.

@brminnick brminnick added the do not merge Do not merge this PR label Aug 4, 2021
@maxkoshevoi
Copy link
Contributor Author

@brminnick Got it, thanks! I'll remove WeakEventManager and ObservableObject when this repo will begin to reference Microsoft.Toolkit.Mvvm/CommunityToolkit.Mvvm (or can I add this reference in this PR?)

@maxkoshevoi
Copy link
Contributor Author

maxkoshevoi commented Sep 3, 2021

@brminnick Added reference to CommunityToolkit.Mvvm and removed duplicated classes (that I've added).
Or should this PR be moved to MVVM alltogated? Not everything here is MVVM related. Two classes only need ObservableObject (which is also useful outside MVVM) and third in markup extension.

@maxkoshevoi maxkoshevoi mentioned this pull request Oct 5, 2021
10 tasks
@maxkoshevoi maxkoshevoi closed this Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization classes migration
4 participants