fix: broken replay files #1308
Merged
fix: broken replay files #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavePearce
force-pushed
the
1307-simple-fix-for-problematic-replays
branch
2 times, most recently
from
8ec2712
to
0a567b2
Compare
This puts in place a simple fix for replay files which incorrectly include StorageSnapshots for accounts which are to be created. Such snapshots confuse BESU into thinking their storage is not empty which, in turn, prevents the accounts from being created (and then fails result checking because the txs in question fail). In principle, this fix should not be necessary because the BlockCapturer has already been fixed to resolve this. However, we still have a number of older replay files in the repository and this fix resolves all of time right now (i.e. so we don't have to wait for them to be recaptured, etc).
DavePearce
force-pushed
the
1307-simple-fix-for-problematic-replays
branch
from
0a567b2
to
8451539
Compare
letypequividelespoubelles
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts in place a simple fix for replay files which incorrectly include StorageSnapshots for accounts which are to be created. Such snapshots confuse BESU into thinking their storage is not empty which, in turn, prevents the accounts from being created (and then fails result checking because the txs in question fail).
In principle, this fix should not be necessary because the BlockCapturer has already been fixed to resolve this. However, we still have a number of older replay files in the repository and this fix resolves all of time right now (i.e. so we don't have to wait for them to be recaptured, etc).