raft: pass gas floor and gas ceil to calcGasLimit when minting block #680
Conversation
…raft-calcgaslimit-1 # Conflicts: # eth/config.go
…raft-calcgaslimit-1
|
On 2.2.4 We originaly set a very high transaction gasLimit - for our scenario we don't care about per tx gasLimit and we don't care about the block level gasLimit. After running for a while, the limit produced by CalcGasLimit was less than our 'fixed' per transaction gasLimit. With the result that all transactions were then rejected by the preCheck with 'exceeds block gas limit" error. Its time consuming to track this down if not aware of the mechanics of this dyamic block gasLimit. We now ensure that 'floor' is very high and transaction gasLimit is < 'floor'. We don't care about the ceiling but considered setting genesis.gasLimit < floor, and floor to be some modestly high value, so we would later have the option of lowering the value for --miner.gastarget and re-enabling the dynamic block gas limit. What does the dynamic limit produced by CalcGasLimit actually give us for a private network ? Is there a reason not to have a fixed limit ? |
raft: pass gas floor and gas ceil to calcGasLimit when minting block
currently raft is using parent gas limit for both floor and ceil and this change is a fix for it