Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block gas limit #700

Closed
Magicking opened this issue Apr 30, 2019 · 9 comments
Closed

Block gas limit #700

Magicking opened this issue Apr 30, 2019 · 9 comments
Assignees
Labels

Comments

@Magicking
Copy link
Contributor

It looks like the 2.2.2 patch imported this commit e8f229b, that changes the default target gas limit to 8,000,000 (ATOW: public ethereum mainnet) instead of the previous higher defined gas limit.

You now need with the 2.2.2+ version to use --miner.gastarget XXX and --miner.gaslimit XXX to set an other gasLimit per block.

Is this an intended behavior?
An update from 2.2.1 to 2.2.2 has the effect without setting this flag to reduce the gasLimit per block to the limit above.

@wenhuancai
Copy link

@Magicking
I would like to temporarily fix this situation, it has affected my release of smart contract, how do I do

@jpmsam
Copy link
Contributor

jpmsam commented May 15, 2019

@wenhuancai you can increase the default low gas limit by setting these flags as suggested by @Magicking --miner.gastarget XXX and --miner.gaslimit XXX.
Since the default limits became configurable in 2.2.2+, we didn't adjust the lower limits but we are fixing that in #680

@jpmsam jpmsam closed this as completed May 15, 2019
@wenhuancai
Copy link

wenhuancai commented May 15, 2019

i don't know how to set --miner.gastarget XXX and --miner.gaslimit XXX.
Is this place set up.(#PRIVATE_CONFIG=azdata/zdsi1/tm.ipc nohup $toolpath/geth --datadir azdata/dd1 $ARGS --permissioned --raftport $RAFPORT --rpccorsdomain "http://localhost:8181" --rpcport $RPCPORT --port $URLPORT --unlock 0 --password passwords.txt 2>>azdata/logs/1.log &
)
I tried it. It's wrong. The program can't communicate.
so,I tried other solutions.
MinerGasCeil: 700000000,
MinerGasCeil: 800000000,
#680,
The script in the sample runs. and a new error has appeared
image
The genesis.json is
image

@SatpalSandhu61
Copy link
Contributor

The "exceeds block gas limit" suggests that you are submitting a transaction with gas which exceeds the block gas limit. You need to either increase gasLimit in the genesis, or reduce the gas supplied for the transaction (ensuring it is still sufficient for the transaction to succeed).

This parameters suggested earlier should be added to the command line, e.g.:

PRIVATE_CONFIG=azdata/zdsi1/tm.ipc nohup $toolpath/geth --datadir azdata/dd1 $ARGS --permissioned --raftport $RAFPORT --rpccorsdomain "http://localhost:8181" --rpcport $RPCPORT --port $URLPORT --unlock 0 --password passwords.txt --miner.gastarget XXXX --miner.gaslimit XXXX 2>>azdata/logs/1.log &

@wenhuancai
Copy link

wenhuancai commented May 15, 2019

image
This one doesn't work

root@2880e441b23a:/home/anzheng# cat runscript.sh
PRIVATE_CONFIG=azdata/zdsi1/tm.ipc geth --miner.gastarget 3300000 --miner.gaslimit 80000000000 --exec "loadScript("$1")" attach ipc:azdata/dd1/geth.ipc
err creating contract Error: exceeds block gas limit
true
root@2880e441b23a:/home/anzheng# cat runscript.sh
PRIVATE_CONFIG=azdata/zdsi1/tm.ipc geth --exec "loadScript("$1")" attach ipc:azdata/dd1/geth.ipc
root@2880e441b23a:/home/anzheng#
Adding to this sample script also does not work

@SatpalSandhu61
Copy link
Contributor

What is the gasLimit in your genesis?

@wenhuancai
Copy link

image

@wenhuancai
Copy link

image
I printed out l to find a limit
image
Gas is max =5000?
Is there anything wrong with the way I write this?

@vasa-develop
Copy link

@wenhuancai did you solve the issue?

petermetz added a commit to petermetz/cacti that referenced this issue Nov 28, 2019
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Nov 28, 2019
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Nov 28, 2019
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Nov 28, 2019
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Nov 28, 2019
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 2, 2019
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 3, 2019
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 3, 2019
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 4, 2019
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 5, 2019
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 5, 2019
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 11, 2019
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 11, 2019
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Dec 21, 2019
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Feb 11, 2020
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Feb 19, 2020
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Feb 21, 2020
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Feb 22, 2020
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Mar 1, 2020
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Mar 2, 2020
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Mar 17, 2020
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Mar 17, 2020
Instead of hardcoding guesses regarding what the CI
environment will produce as a gas price for the contract
deployment be pro-active, ask for a quote and then offer to
spend the quote + a million gas to be on the safe side. This
should guarantee that there will be enough gas unless there's a
bug in the underlying network (which has happened in the past,
quorum had a gas bug where it was asking for more than the
maximum possible gas).

Also downgraded quorum to v2.2.5 because that is considered
stabl while 2.3.0 is a beta release and therefore it is possible
that has issues with the gas estimates like previous versions did.

Changed the gas upper and lower bounds for blocks through the
newly introduced CLI flags of Quorum eth:
Consensys/quorum#700 (comment)
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L333
https://github.com/jpmorganchase/quorum/blob/v2.2.5/cmd/utils/flags.go#L343

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants