Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a lock around WriteBlockWithState while processing sealing result #684

Merged
merged 4 commits into from
May 20, 2019
Merged

Adding a lock around WriteBlockWithState while processing sealing result #684

merged 4 commits into from
May 20, 2019

Conversation

jbhurat
Copy link
Contributor

@jbhurat jbhurat commented Apr 17, 2019

Fixes #653 and #676

Locking WriteBlockWithState call in worker, resolving concurrent map access panics seen in #653 and #676

@jbhurat jbhurat requested a review from jpmsam April 17, 2019 17:28
@jbhurat
Copy link
Contributor Author

jbhurat commented Apr 17, 2019

lock around WriteBlockWithState call was added in ethereum/go-ethereum#17173, but was later removed when the worker sealing logic was rewritten

@jbhurat jbhurat mentioned this pull request Apr 19, 2019
Closed
@jbhurat jbhurat mentioned this pull request Apr 25, 2019
Closed
@jpmsam jpmsam merged commit 89f811a into Consensys:master May 20, 2019
@SatpalSandhu61 SatpalSandhu61 mentioned this pull request Dec 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmsam jpmsam jpmsam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quorum crashed on heavy loading with clique consensus.
2 participants
@jbhurat @jpmsam