miner: Concurrent read/write during contract deployment (issue #16933) #17173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge latest geth changes
Latest changes from go-ethereum
Pull latest changes from go-ethereum
Take latest changes from go-ethereum
Bring latest changes from original geth
Pull in the latest changes from go-ethereum
Pull latest changes from go-ethereum
Bring in latest changes from go-ethereum
Pull latest changes from geth
Pull latest changes from go-ethereum
Pull latest changes from go-ethereum
pull latest changes from go-ethereum
pull 1.8.4
Pull latest changes from go-ethereum
pull latest changes from go-ethereum
Pull go-ethereum 1.8.11
Pull 1.8.12
Pull latest changes from go-ethereum
|
Not my favorite solution btw since we seem to hold the wrong lock, but since we're rewriting the miner soon-ish anyway, this fast solution will be fine. |
prolands
reviewed
Jul 31, 2018
firmianavan
pushed a commit
to firmianavan/go-ethereum
that referenced
this pull request
Aug 28, 2018
hello2mao
pushed a commit
to hello2mao/go-ethereum
that referenced
this pull request
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for this #16933
Copy of my analysis from the issue:
Ok, I think I figured out where this race is coming from. Here: https://github.com/ethereum/go-ethereum/blob/v1.8.10/miner/worker.go#L499 the "work", containing pointer to the "current.state" gets pushed to the channel for the agents to process.
Agent processes it (finds nonce), wraps it into a "Result" and puts it into the "recv" channel. Here we read it from "recv" channel: https://github.com/ethereum/go-ethereum/blob/v1.8.10/miner/worker.go#L301.
Next, we call "WriteBlockWithState" here, passing the same state: https://github.com/ethereum/go-ethereum/blob/v1.8.10/miner/worker.go#L320.
Inside WriteBlockWithState, we call state.Commit here: https://github.com/ethereum/go-ethereum/blob/v1.8.10/core/blockchain.go#L902, which mutates the state. When it happens, we are not holding the "currentMu" lock, which means the call to "pending" can proceed concurrently
Fix is empirically verified by the OP of the issue