Make sealing synchronous #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amalrajmani
reviewed
Oct 3, 2019
amalrajmani
reviewed
Oct 3, 2019
amalrajmani
reviewed
Oct 3, 2019
prd-fox
force-pushed
the
bugfix/make-sealing-synchronous
branch
2 times, most recently
from
b80e53f to
3a031ff
Compare
Fix private tx receipt setting on tasks Remove now unnecessary locking when writing state Move delay creation outside of goroutine to mimic Clique sealing Handle errors appropriately
prd-fox
force-pushed
the
bugfix/make-sealing-synchronous
branch
from
fbb63d5 to
2dd2a28
Compare
jpmsam
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There exists some race condition when minting blocks with IBFT/Clique.
This is where a block is created, but then discarded to try again. The state is reverted and txpool reset, but fails. This also happens as we are performing operations on a constantly changing global state, instead of copies of state.
A few issues that can happen:
Fixes #830