-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new BlobSidecar #7668
Add new BlobSidecar #7668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with few nits
@@ -7,4 +7,6 @@ FIELD_ELEMENTS_PER_BLOB: 4096 | |||
# `uint64(2**12)` (= 4096) | |||
MAX_BLOB_COMMITMENTS_PER_BLOCK: 4096 | |||
# `uint64(6)` | |||
MAX_BLOBS_PER_BLOCK: 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also 3 deneb.yaml files that need to be updated under ethereum/spec/src/test/resources/tech/pegasys/teku/spec/config/standard/presets
} | ||
|
||
public BlobSidecar( | ||
BlobSidecarSchema schema, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final
🗡️
@@ -58,6 +59,7 @@ public SpecConfigDeneb build(final SpecConfigCapella specConfig) { | |||
maxRequestBlobSidecars, | |||
minEpochsForBlobSidecarsRequests, | |||
blobSidecarSubnetCount, | |||
kzgCommitmentInclusionProofDepth, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super nit but would add this variable under maxBlobsPerBlock
to align with the spec ordering
PR Description
Includes
Part of #7654
Fixed Issue(s)
Documentation
doc-change-required
label to this PR if updates are required.Changelog