[Deneb] Remove BlindedBlobSidecar and clean up block production/publishing flow
#7691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
beacon/validator/src/main/java/tech/pegasys/teku/validator/coordinator/BlockFactoryDeneb.java
Fixed
Show fixed
Hide fixed
zilm13
approved these changes
Nov 12, 2023
beacon/validator/src/main/java/tech/pegasys/teku/validator/coordinator/BlockFactoryDeneb.java
Outdated
Show resolved
Hide resolved
| assertThat(blobSidecarsUnblinder.blobsBundle) | ||
| .isCompletedWithValue(executionPayloadAndBlobsBundle.getBlobsBundle()); | ||
| } | ||
|
|
||
| private void prepareBlockProductionWithPayload( |
There was a problem hiding this comment.
We will have the same flow here for blinded and unblinded? Why shouldSetBlobsBundle_whenAcceptingTheBlobSidecarsUnblinderSelector is no more needed?
There was a problem hiding this comment.
I basically deleted the method, not sure right now what would be the best way to do this, so will add test when working on the block production.
StefanBratanov
force-pushed
the
blinded_blob_sidecar_cleanup
branch
from
e35d1ad to
fe54ade
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
BlindedBlobSidecar,SignedBlindedBlobSidecarand all related classes.BlockFactoryDenebBlindBlockUtilDenebso simplification thereFixed Issue(s)
helps with block production flow for #7654
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog