Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change BlobSidecarGossipManager to use the new BlobSidecar type #7694

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Change BlobSidecarGossipManager to use the new BlobSidecar type #7694

merged 2 commits into from
Nov 13, 2023

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Nov 13, 2023 •
edited
Loading

PR Description

  • Essentially change BlobSidecarGossipManager to use the new BlobSidecar container
  • Add new method validateAndPrepareForBlockImport in BlobSidecarManager and deprecate the old one. Will implement in future PR.
  • Change publishBlobSidecarsin BlobSidecarGossipChannel to use the new BlobSidecar container and used it in BlockPublisherDeneb sending an empty list. Will implement in future PR.

Fixed Issue(s)

helps with gossip flow for #7654

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

tbenr
tbenr approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov merged commit 5c4fe24 into Consensys:master Nov 13, 2023
14 checks passed
@StefanBratanov StefanBratanov deleted the change_gossip_blob_sidecar branch November 13, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbenr tbenr tbenr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanBratanov @tbenr