Optimize BlobSidecarGossipValidator #7749
Conversation
| @@ -63,14 +65,17 @@ public static BlobSidecarGossipValidator create( | |||
| final Optional<Integer> maybeMaxBlobsPerBlock = spec.getMaxBlobsPerBlock(); | |||
|
|
|||
| final int validInfoSize = VALID_BLOCK_SET_SIZE * maybeMaxBlobsPerBlock.orElse(1); | |||
| // It's not fatal if we miss something and we don't need finalized data | |||
| final int validSignedBlockHeadersSize = spec.getGenesisSpec().getSlotsPerEpoch() * 3; | |||
There was a problem hiding this comment.
I'd rather extract the 3 to a config constant
There was a problem hiding this comment.
yeah, and it could have a proper name, it's not a magic number, will do it
|
@mehdi-aouadi I want to keep order the same as in the spec in long case and the checks we need in short case are not all one by one from it, I've tried to reuse it first time, but it actually looks not so good. |
| blobSidecar.getIndex()))) { | ||
| return ignore( | ||
| "BlobSidecar is not the first valid for its slot and index. It will be dropped."); | ||
| synchronized (this) { |
There was a problem hiding this comment.
why synchronised when using LimitedSet.createSynchronized ?
There was a problem hiding this comment.
"It is imperative that the user manually synchronize on the returned map when traversing any of its collection views via Iterator, Spliterator or Stream:"
Looks like we are safe on atomic operations, removed
|
LGTM to me as well |
PR Description
Fixed Issue(s)
Fixes #7654
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog