PART 3 - GET/Attestation Pool API - Add API interface

[mehdi-aouadi]

PR Description

Add the new GetAttestationV2 /eth/v2/beacon/pool/attestations

Fixed Issue(s)

#8029

Documentation

• I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

• I thought about adding a changelog entry, and added one if I deemed necessary.

[greptile-apps]

PR Summary

• Added new API endpoint /eth/v2/beacon/pool/attestations (data/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v2/beacon/GetAttestationsV2.java)
• Deprecated old endpoint /eth/v1/beacon/pool/attestations (data/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v1/beacon/GetAttestations.java)
• Updated DataProvider and NodeDataProvider to support new endpoint (data/provider/src/main/java/tech/pegasys/teku/api/DataProvider.java, data/provider/src/main/java/tech/pegasys/teku/api/NodeDataProvider.java)
• Added integration and unit tests for new endpoint (data/beaconrestapi/src/test/java/tech/pegasys/teku/beaconrestapi/handlers/v2/beacon/GetAttestationsV2Test.java)
• Updated AggregatingAttestationPool to handle new attestation schema (ethereum/statetransition/src/main/java/tech/pegasys/teku/statetransition/attestation/AggregatingAttestationPool.java)

_{15 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

PR Summary

(updates since last review)

• Deprecated v1 attestation pool API endpoint (/data/beaconrestapi/src/integration-test/resources/tech/pegasys/teku/beaconrestapi/beacon/paths/_eth_v1_beacon_pool_attestations.json)
• Marked v1 endpoint as deprecated in preparation for v2 API

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

PR Summary

(updates since last review)

• Added new /eth/v2/beacon/pool/attestations endpoint in GetAttestationsV2.java
• Implemented getAttestationsAndMetaData method in NodeDataProvider.java
• Created JSON schema for v2 attestation response in GetPoolAttestationsV2Response.json
• Added unit tests for GetAttestationsV2 in GetAttestationsV2Test.java
• Updated AggregatingAttestationPool.java to support different attestation formats

_{16 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

PR Summary

(updates since last review)

The pull request introduces a new API interface for retrieving attestations from the attestation pool, focusing on the /eth/v2/beacon/pool/attestations endpoint.

• Added GetAttestationsV2.java to handle the new /eth/v2/beacon/pool/attestations endpoint.
• Updated NodeDataProvider.java to include methods for fetching attestations and their metadata.
• Introduced JSON schema for v2 attestation responses in GetPoolAttestationsV2Response.json.
• Deprecated the old v1 endpoint in GetAttestations.java.
• Added unit tests for the new endpoint in GetAttestationsV2Test.java.

_{58 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[tbenr]

as discussed in call, the current commiteeIndex filter requires an update. We can leverage the committee filtering we already have for the aggregation flow, but requires to be updated to cover the phase0 because it has been design for electra only.

[mehdi-aouadi]

as discussed in call, the current commiteeIndex filter requires an update. We can leverage the committee filtering we already have for the aggregation flow, but requires to be updated to cover the phase0 because it has been design for electra only.

Done, made the filter applied differently based on the milestone. Pre electra we apply the filter to the index at the attestation data level and post Electra we rather apply it to the committee bits

[tbenr]

LGTM